-
Notifications
You must be signed in to change notification settings - Fork 2
fix(main): make examples runnable #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Scott Hamrick <2623452+cshamrick@users.noreply.github.com>
Summary of ChangesHello @cshamrick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the usability of the OpenTDF Java SDK examples by making them directly runnable and providing comprehensive documentation. The changes streamline the process for developers to interact with and learn from the example code, enhancing the overall developer experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes the Java SDK examples runnable by updating the examples/pom.xml to configure the exec-maven-plugin for each example, and by adding a README.md with clear instructions. The changes are well-executed and achieve the goal. My review includes one suggestion to enhance the new documentation for better usability.
|
X-Test Failure Report |
X-Test Failure Report |
X-Test Results✅ go-v0.4.34 |
mkleene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good idea!
🤖 I have created a release *beep* *boop* --- <details><summary>0.11.0</summary> ## [0.11.0](v0.10.0...v0.11.0) (2025-11-20) ### Features * **ci:** DSPX-1716 Updating permission for bundled tests ([#306](#306)) ([87ff3e6](87ff3e6)) ### Bug Fixes * **ci:** Fix the workflow that updates the proto version ([#301](#301)) ([9bd9ce5](9bd9ce5)) * **main:** make examples runnable ([#311](#311)) ([5ede7dd](5ede7dd)) * parse hostnames with no ports correctly ([#292](#292)) ([3da5f51](3da5f51)) * **sdk:** remove reserved and unused proto field ([#299](#299)) ([50b0302](50b0302)) * we can't parse things like `192.168.1.1:4000` ([#294](#294)) ([dc3142d](dc3142d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>



This change updates
examples/pom.xmland adds a readme with instructions for how to run the examples.