Skip to content

Conversation

@cshamrick
Copy link
Contributor

This change updates examples/pom.xml and adds a readme with instructions for how to run the examples.

Signed-off-by: Scott Hamrick <2623452+cshamrick@users.noreply.github.com>
@cshamrick cshamrick requested review from a team as code owners November 18, 2025 15:40
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cshamrick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the usability of the OpenTDF Java SDK examples by making them directly runnable and providing comprehensive documentation. The changes streamline the process for developers to interact with and learn from the example code, enhancing the overall developer experience.

Highlights

  • Runnable Examples: The examples for the OpenTDF Java SDK are now runnable, making it easier for users to test and understand the SDK's functionalities.
  • New README.md: A new examples/README.md file has been added, providing clear instructions on how to execute each example using the exec-maven-plugin.
  • Maven Configuration Update: The examples/pom.xml has been updated to configure the exec-maven-plugin with individual execution IDs for each example, allowing them to be run by name (e.g., mvn exec:java@EncryptExample).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the Java SDK examples runnable by updating the examples/pom.xml to configure the exec-maven-plugin for each example, and by adding a README.md with clear instructions. The changes are well-executed and achieve the goal. My review includes one suggestion to enhance the new documentation for better usability.

@cshamrick cshamrick changed the title fix(examples): make examples runnable fix(main): make examples runnable Nov 18, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link

X-Test Failure Report

✅ go-v0.4.34
✅ js-main
✅ java-main

@github-actions
Copy link

X-Test Failure Report

✅ go-v0.4.34
✅ js-main
✅ java-main
✅ js-v0.4.34

@github-actions
Copy link

Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good idea!

@cshamrick cshamrick merged commit 5ede7dd into main Nov 20, 2025
36 of 49 checks passed
@cshamrick cshamrick deleted the fix-examples branch November 20, 2025 20:16
strantalis pushed a commit that referenced this pull request Dec 2, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>0.11.0</summary>

##
[0.11.0](v0.10.0...v0.11.0)
(2025-11-20)


### Features

* **ci:** DSPX-1716 Updating permission for bundled tests
([#306](#306))
([87ff3e6](87ff3e6))


### Bug Fixes

* **ci:** Fix the workflow that updates the proto version
([#301](#301))
([9bd9ce5](9bd9ce5))
* **main:** make examples runnable
([#311](#311))
([5ede7dd](5ede7dd))
* parse hostnames with no ports correctly
([#292](#292))
([3da5f51](3da5f51))
* **sdk:** remove reserved and unused proto field
([#299](#299))
([50b0302](50b0302))
* we can't parse things like `192.168.1.1:4000`
([#294](#294))
([dc3142d](dc3142d))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants