chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue by dmihalcik-virtru · Pull Request #3971 · opentdf/platform

dmihalcik-virtru · 2026-09-03T19:52:39Z

Part of the DSPX-4607 lint burndown, following the golangci-lint v2.13.2 bump (#3965, merged). Branched from main, independent of the other burndown PRs.

What

lib/fixtures has 26 findings, all in keycloak.go:

25 × nolintlint — //nolint:sloglint // allow existing emojis directives that no longer suppress anything:

lib/fixtures/keycloak.go:168:3: directive `//nolint:sloglint // allow existing emojis` is unused for linter "sloglint" (nolintlint)

sloglint's msg-style: lowercased no longer objects to messages that begin with an emoji ("✅ realm created", "⏭️ realm already exists"), so every one of these directives is now dead. Deleted rather than kept, since nolintlint is what flags them and a stale directive is worse than none — it silently suppresses future real findings.

1 × goconst — six raw "true" map values duplicating the keycloakBoolTrue constant already declared at line 25. Replaced those six, plus the one gocloak.StringP("true") at line 274 that goconst skips (ignore-calls is on by default) — leaving a lone raw literal next to six converted ones would just be untidy.

Net: 32 deletions, 7 insertions. No behaviour change — the emitted log messages and the Keycloak config values are byte-identical.

Testing

$ cd lib/fixtures && golangci-lint run -c ../../.golangci.yaml
0 issues.

Pre-existing test failures (not from this PR)

go test ./... fails two tests, identically on unmodified main:

--- FAIL: TestTokenManager_InitialLogin
    keycloak_token_manager_test.go:43: Expected default token buffer of 120s, got 30s
--- FAIL: TestTokenManager_CustomTokenBuffer
    keycloak_token_manager_test.go:73: Expected token buffer of 1m0s, got 30s

Verified by jj restore --from main lib/fixtures/keycloak.go and re-running — same two failures. They're in keycloak_token_manager.go, which this PR doesn't touch; the "adjusted token buffer for short token lifetime" clamp is overriding the configured buffer. Out of scope here, but worth a separate look.

DSPX-4607 burndown index

chore(ci): DSPX-4607 bump golangci-lint to v2.13.2 #3965 — golangci-lint v2.13.2 bump (merged)
chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968 — .golangci.yaml goconst tuning + gomodguard_v2 migration (merged)
Siblings: fix(cli): DSPX-4607 annotate deprecated Action.Value use in migration test #3969 (otdfctl), fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake #3970 (service/kas), fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973 (sdk), fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974 (examples), fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975 (tests-bdd), fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977 (service/policy), fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978 (service core)

coderabbitai · 2026-09-03T19:52:49Z

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 6b3b8616-68ce-4e3a-9301-19f1fca4d93e

📥 Commits

Reviewing files that changed from the base of the PR and between d5933ed and 485c233.

📒 Files selected for processing (1)

lib/fixtures/keycloak.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-03T19:59:27Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	214.1179ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	130.383676ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	443.228674ms
Throughput	225.62 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	55.202374424s
Average Latency	550.818795ms
Throughput	90.58 requests/second

github-actions · 2026-09-03T20:09:19Z

X-Test Results

✅ go@pull-3971-main
bats-test-results
✅ go@main-main
✅ go@pull-3971-pull-3971
✅ go@main-v0.9.0
✅ go@pull-3971-v0.9.0
✅ go@main-pull-3971
✅ java@main-main
✅ java@main-pull-3971
✅ js@main-pull-3971
✅ java@main-v0.9.0
✅ js@main-main
✅ js@main-v0.9.0
cukes-report
opentdf~~platform~~BFTS99.dockerbuild
govulncheck-failure-3
govulncheck-failure-1
govulncheck-failure-8

github-actions · 2026-09-03T21:46:20Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	247.222642ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	143.022956ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	431.432547ms
Throughput	231.79 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m1.777698747s
Average Latency	616.311433ms
Throughput	80.94 requests/second

github-actions · 2026-09-03T21:54:22Z

X-Test Results

✅ go@main-main
✅ go@main-pull-3971
✅ go@pull-3971-pull-3971
bats-test-results
✅ go@pull-3971-v0.9.0
✅ go@main-v0.9.0
✅ go@pull-3971-main
cukes-report
✅ java@main-main
✅ js@main-pull-3971
✅ java@main-pull-3971
✅ java@main-v0.9.0
✅ js@main-main
✅ js@main-v0.9.0
opentdf~~platform~~WBNTB2.dockerbuild
govulncheck-failure-8
govulncheck-failure-3
govulncheck-failure-1

…reuse keycloakBoolTrue golangci-lint v2.13.2 reports 26 findings in lib/fixtures: - 25 //nolint:sloglint directives that no longer suppress anything. sloglint stopped flagging the emoji log messages they were added for, so nolintlint now reports each as unused. - 6 raw "true" map values that duplicate the existing keycloakBoolTrue constant. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>

Invalidated by push of 485c233

github-actions · 2026-09-04T13:19:09Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	226.893322ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	126.59439ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	458.977658ms
Throughput	217.88 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	55.694042893s
Average Latency	555.5879ms
Throughput	89.78 requests/second

github-actions · 2026-09-04T13:21:08Z

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

otdfctl
service
tests-bdd

See the workflow run for details.

github-actions · 2026-09-04T13:28:16Z

X-Test Results

✅ go@pull-3971-pull-3971
✅ go@main-pull-3971
✅ go@main-main
bats-test-results
✅ go@pull-3971-v0.9.0
✅ go@main-v0.9.0
✅ go@pull-3971-main
✅ java@main-pull-3971
✅ java@main-main
✅ java@main-v0.9.0
✅ js@main-main
✅ js@main-pull-3971
cukes-report
✅ js@main-v0.9.0
opentdf~~platform~~LUZY12.dockerbuild
govulncheck-failure-3
govulncheck-failure-8
govulncheck-failure-1

dmihalcik-virtru requested review from a team as code owners September 3, 2026 19:52

github-actions Bot added comp:lib:fixtures size/s labels Sep 3, 2026

dmihalcik-virtru force-pushed the fix/lint-fixtures-nolint branch from 6bde4c7 to c729b44 Compare September 3, 2026 21:39

dmihalcik-virtru mentioned this pull request Sep 3, 2026

chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968

Merged

This was referenced Sep 3, 2026

fix(examples): DSPX-4607 clear goconst and SA1019 lint findings #3974

Open

fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975

Open

jakedoublev previously approved these changes Sep 3, 2026

View reviewed changes

This was referenced Sep 4, 2026

fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977

Open

fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978

Open

dmihalcik-virtru force-pushed the fix/lint-fixtures-nolint branch from c729b44 to 485c233 Compare September 4, 2026 13:13

dmihalcik-virtru changed the title ~~chore(fixtures): DSPX-4607 drop stale nolint directives and reuse keycloakBoolTrue~~ chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue Sep 4, 2026

This was referenced Sep 4, 2026

fix(cli): DSPX-4607 annotate deprecated Action.Value use in migration test #3969

Open

fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake #3970

Open

fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973

Open

Uh oh!

Conversation

dmihalcik-virtru commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Testing

Pre-existing test failures (not from this PR)

DSPX-4607 burndown index

Uh oh!

coderabbitai Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 3, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 3, 2026

X-Test Results

Uh oh!

github-actions Bot commented Sep 4, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions Bot commented Sep 4, 2026

⚠️ Govulncheck found vulnerabilities ⚠️

Uh oh!

github-actions Bot commented Sep 4, 2026

X-Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dmihalcik-virtru commented Sep 3, 2026 •

edited

Loading

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading