Skip to content

Adjust Multi-Sig Deposit#282

Closed
camfairchild wants to merge 3 commits into
developmentfrom
adjust-multisig-fee
Closed

Adjust Multi-Sig Deposit#282
camfairchild wants to merge 3 commits into
developmentfrom
adjust-multisig-fee

Conversation

@camfairchild
Copy link
Copy Markdown
Contributor

@camfairchild camfairchild commented Mar 23, 2024

This PR affects the multi-sig deposit in two ways:

  1. Fixes the deposit base calculation to match the multi-sig pallet comments (link)
  2. Lowers the deposit base by adjusting the constant terms
    • e.g. 0.172 for a 2/2 multi-sig becomes 0.0476
      • and 0.0572 after the first change

@camfairchild camfairchild changed the title Adjust Multi-Sig Fee Adjust Multi-Sig Deposit Mar 26, 2024
@unconst unconst changed the base branch from main to development March 27, 2024 17:13
@open-junius
Copy link
Copy Markdown
Contributor

pls close this one. the code change already included in #286

Comment thread runtime/src/lib.rs
// One storage item; key size is 32; value is size 4+4+16+32 bytes = 56 bytes.
pub const DepositBase: Balance = (1) as Balance * 2_000 * 10_000 + (88 as Balance) * 100 * 10_000;
// One storage item; key size is 32 + sizeof(AccountId) = 64; value is size 4 + sizeof((BlockNumber, Balance, AccountId)) = 56;
// = 120 bytes total.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value size is 4 + 4 block number + 8 balance + 32 account id = 48

@camfairchild
Copy link
Copy Markdown
Contributor Author

Closing in-favour of #286

@distributedstatemachine distributedstatemachine deleted the adjust-multisig-fee branch June 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants