Adjust Multi-Sig Deposit#282
Closed
camfairchild wants to merge 3 commits into
Closed
Conversation
Contributor
|
pls close this one. the code change already included in #286 |
open-junius
reviewed
Apr 16, 2024
| // One storage item; key size is 32; value is size 4+4+16+32 bytes = 56 bytes. | ||
| pub const DepositBase: Balance = (1) as Balance * 2_000 * 10_000 + (88 as Balance) * 100 * 10_000; | ||
| // One storage item; key size is 32 + sizeof(AccountId) = 64; value is size 4 + sizeof((BlockNumber, Balance, AccountId)) = 56; | ||
| // = 120 bytes total. |
Contributor
There was a problem hiding this comment.
value size is 4 + 4 block number + 8 balance + 32 account id = 48
Contributor
Author
|
Closing in-favour of #286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR affects the multi-sig deposit in two ways:
0.172for a2/2multi-sig becomes0.04760.0572after the first change