Skip to content

[tests] remove border router MATN tests - #13306

Merged
jwhui merged 1 commit into
openthread:mainfrom
jwhui:remove-matn-tests
Jul 6, 2026
Merged

[tests] remove border router MATN tests#13306
jwhui merged 1 commit into
openthread:mainfrom
jwhui:remove-matn-tests

Conversation

@jwhui

@jwhui jwhui commented Jul 6, 2026

Copy link
Copy Markdown
Member

Remove MATN border router certification tests as they have been replaced by equivalent tests in the ot-br-posix repository under: https://github.com/openthread/ot-br-posix/tree/main/tests/scripts/expect

The new tests run using the docker-in-docker framework.

Deleted tests:

  • MATN_02_MLRFirstUse.py
  • MATN_03_InvalidCommissionerDeregistration.py
  • MATN_04_MulticastListenerTimeout.py
  • MATN_05_ReregistrationToSameMulticastGroup.py
  • MATN_09_DefaultBRMulticastForwarding.py
  • MATN_12_HopLimitProcessing.py
  • MATN_15_ChangeOfPrimaryBBRTriggersRegistration.py
  • MATN_16_LargeNumberOfMulticastGroupSubscriptionsToBBR.py

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes several legacy MATN border router certification tests. These tests have been replaced by updated, equivalent implementations in the ot-br-posix repository that utilize the docker-in-docker testing framework, streamlining the testing process and ensuring better maintenance.

Highlights

  • Cleanup of obsolete tests: Removed eight MATN border router certification tests that have been superseded by equivalent tests in the ot-br-posix repository.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several multicast-related integration test files (MATN_02, MATN_03, MATN_04, MATN_05, MATN_09, MATN_12, MATN_15, and MATN_16) from the test suite. As there are no review comments provided, I have no additional feedback to offer.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging #13306 into main

name branch text data bss total
ot-cli-ftd 815264e 480920 860 66508 548288
55778d1 480920 860 66508 548288
+/- +0 +0 +0 +0
ot-ncp-ftd 815264e 446300 764 61744 508808
55778d1 446300 764 61744 508808
+/- +0 +0 +0 +0
ot-cli-mtd 815264e 373624 764 50908 425296
55778d1 373624 764 50908 425296
+/- +0 +0 +0 +0
ot-ncp-mtd 815264e 354956 764 46176 401896
55778d1 354956 764 46176 401896
+/- +0 +0 +0 +0
ot-cli-ftd-br 815264e 592312 864 130660 723836
55778d1 592312 864 130660 723836
+/- +0 +0 +0 +0
ot-rcp 815264e 63936 568 20812 85316
55778d1 63936 568 20812 85316
+/- +0 +0 +0 +0
Library files
name branch text data bss total
libopenthread-ftd.a 815264e 250140 95 40287 290522
55778d1 250140 95 40287 290522
+/- +0 +0 +0 +0
libopenthread-cli-ftd.a 815264e 61777 0 8091 69868
55778d1 61777 0 8091 69868
+/- +0 +0 +0 +0
libopenthread-ncp-ftd.a 815264e 33359 0 5948 39307
55778d1 33359 0 5948 39307
+/- +0 +0 +0 +0
libopenthread-mtd.a 815264e 170146 0 24719 194865
55778d1 170146 0 24719 194865
+/- +0 +0 +0 +0
libopenthread-cli-mtd.a 815264e 41482 0 8059 49541
55778d1 41482 0 8059 49541
+/- +0 +0 +0 +0
libopenthread-ncp-mtd.a 815264e 25783 0 5948 31731
55778d1 25783 0 5948 31731
+/- +0 +0 +0 +0
libopenthread-ftd-br.a 815264e 362242 99 104399 466740
55778d1 362242 99 104399 466740
+/- +0 +0 +0 +0
libopenthread-cli-ftd-br.a 815264e 80892 0 8131 89023
55778d1 80892 0 8131 89023
+/- +0 +0 +0 +0
libopenthread-rcp.a 815264e 9946 0 5060 15006
55778d1 9946 0 5060 15006
+/- +0 +0 +0 +0
libopenthread-radio.a 815264e 20637 0 246 20883
55778d1 20637 0 246 20883
+/- +0 +0 +0 +0

Remove MATN border router certification tests as they have been
replaced by equivalent tests in the ot-br-posix repository under:
https://github.com/openthread/ot-br-posix/tree/main/tests/scripts/expect

The new tests run using the docker-in-docker framework.

Deleted tests:
- MATN_02_MLRFirstUse.py
- MATN_03_InvalidCommissionerDeregistration.py
- MATN_04_MulticastListenerTimeout.py
- MATN_05_ReregistrationToSameMulticastGroup.py
- MATN_09_DefaultBRMulticastForwarding.py
- MATN_12_HopLimitProcessing.py
- MATN_15_ChangeOfPrimaryBBRTriggersRegistration.py
- MATN_16_LargeNumberOfMulticastGroupSubscriptionsToBBR.py
@jwhui
jwhui force-pushed the remove-matn-tests branch from 756f642 to 4a6b4b7 Compare July 6, 2026 20:19
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (815264e) to head (4a6b4b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13306      +/-   ##
==========================================
+ Coverage   70.34%   72.59%   +2.25%     
==========================================
  Files         703      704       +1     
  Lines       96719    94405    -2314     
==========================================
+ Hits        68034    68538     +504     
+ Misses      28685    25867    -2818     

see 154 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jwhui
jwhui marked this pull request as ready for review July 6, 2026 21:39
@jwhui
jwhui merged commit 8bb5b30 into openthread:main Jul 6, 2026
95 of 96 checks passed
@jwhui
jwhui deleted the remove-matn-tests branch July 6, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants