Skip to content

fix(style): adapt feedback and welcome to dark mode - #336

Merged
SonyLeo merged 2 commits into
opentiny:developfrom
gene9831:styles/feedback-issues
Apr 29, 2026
Merged

fix(style): adapt feedback and welcome to dark mode#336
SonyLeo merged 2 commits into
opentiny:developfrom
gene9831:styles/feedback-issues

Conversation

@gene9831

@gene9831 gene9831 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style
    • Updated component theming to use CSS variables instead of hardcoded colors for consistent visual appearance
    • Added dark mode support to feedback components
    • Enhanced visual consistency across action group, feedback, and welcome components with theme-driven styling

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@gene9831 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 15 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a9e852e7-6bf8-4af3-b302-34b694fb8970

📥 Commits

Reviewing files that changed from the base of the PR and between 495c1f7 and a7fdb7f.

📒 Files selected for processing (1)
  • packages/components/src/feedback/index.vue

Walkthrough

This PR updates multiple component styling across the codebase to use CSS variables and theme tokens instead of hardcoded color values, enabling consistent theme application and dark mode support throughout the component library.

Changes

Cohort / File(s) Summary
Component Theme Styling Updates
packages/components/src/action-group/ActionGroup.vue, packages/components/src/feedback/components/SourceList.vue, packages/components/src/feedback/index.vue, packages/components/src/welcome/index.vue
Migrated dropdown, pill, and button styling from hardcoded colors to CSS variables (--tr-text-primary, --tr-text-secondary, --tr-feedback-source-pill-*). Added dark mode support via :global([data-tr-color-mode='dark']) selector in SourceList and theme-driven variables throughout.
Demo Styling Updates
docs/demos/welcome/align.vue
Refactored controls container from inline flex styles to dedicated align-controls CSS class using scoped Less with CSS variables for text coloring and deep selector for radio button theming.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰✨ A colorful hop through variables bright,
No more hardcoded colors, just light and might!
CSS tokens dance, dark mode takes flight,
Theming so smooth, everything feels right! 🎨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adapting feedback and welcome components to support dark mode through CSS variable refactoring across multiple component files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 20 minutes and 15 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/components/src/feedback/index.vue`:
- Around line 147-150: The current CSS variable mappings assign hover source
vars to active destination tokens (e.g., --tv-Button-bg-color-active-default)
causing hover styles not to apply; update the mappings so the hover destination
tokens are used instead: replace --tv-Button-bg-color-active-default,
--tv-Button-border-color-active-default, and
--tv-Button-text-color-active-default with --tv-Button-bg-color-hover-default,
--tv-Button-border-color-hover-default, and --tv-Button-text-color-hover-default
respectively and point each to the corresponding --tr-feedback-button-*-hover
variable to restore correct TinyButton hover behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 24f7a8e9-b38e-4dc0-8eea-b1c9b9474e24

📥 Commits

Reviewing files that changed from the base of the PR and between 5bc319a and 495c1f7.

⛔ Files ignored due to path filters (3)
  • packages/svgs/src/assets/dislike.svg is excluded by !**/*.svg
  • packages/svgs/src/assets/like.svg is excluded by !**/*.svg
  • packages/svgs/src/assets/menu.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • docs/demos/welcome/align.vue
  • packages/components/src/action-group/ActionGroup.vue
  • packages/components/src/feedback/components/SourceList.vue
  • packages/components/src/feedback/index.vue
  • packages/components/src/welcome/index.vue

Comment thread packages/components/src/feedback/index.vue
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

✅ Preview build completed successfully!

Click the image above to preview.
Preview will be automatically removed when this PR is closed.

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@SonyLeo
SonyLeo merged commit d346071 into opentiny:develop Apr 29, 2026
4 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleaned Up

The preview deployment has been removed.

@gene9831
gene9831 deleted the styles/feedback-issues branch April 29, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: 暗黑模式,点赞点踩等图标按钮颜色不正确,显示不出来

2 participants