Skip to content

Conversation

@binh-dam-ibigroup
Copy link
Collaborator

This PR starts integrating the from/to location pickers from @opentripplanner/otp-ui into otp-react-redux.

<LocationIcon type='to' /> To here
</Button>
</div>
<FromToLocationPicker onFromClick={this._setFromClicked} onToClick={this._setToClicked} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to completely replace the SetFromToButtons component with the FromToLocationPicker? The FromToLocationPicker is able to call a setLocation method with the same arguments that are in here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will decline for now. We will need our own Popup class for use inside overlays and inside BaseMap before we can inline SetFromToButtons. Right now, SetFromToButtons takes in a map so it can close the popup when you click on the links.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about replacing the set-from-to.js file with this otp-ui package. If it's easy to replace this component, then I think we should.

@evansiroky evansiroky removed their assignment Feb 18, 2020
@landonreed landonreed merged commit c84de22 into dev Feb 25, 2020
@landonreed landonreed deleted the using-new-otp-ui-components branch February 25, 2020 16:19
@landonreed
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@landonreed
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants