-
Notifications
You must be signed in to change notification settings - Fork 58
From-To-Location-Picker #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <LocationIcon type='to' /> To here | ||
| </Button> | ||
| </div> | ||
| <FromToLocationPicker onFromClick={this._setFromClicked} onToClick={this._setToClicked} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to completely replace the SetFromToButtons component with the FromToLocationPicker? The FromToLocationPicker is able to call a setLocation method with the same arguments that are in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will decline for now. We will need our own Popup class for use inside overlays and inside BaseMap before we can inline SetFromToButtons. Right now, SetFromToButtons takes in a map so it can close the popup when you click on the links.
evansiroky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about replacing the set-from-to.js file with this otp-ui package. If it's easy to replace this component, then I think we should.
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR starts integrating the from/to location pickers from @opentripplanner/otp-ui into otp-react-redux.