Skip to content

Conversation

binh-dam-ibigroup and others added 30 commits February 12, 2020 21:20
- this only shows up when user data is stored and shown
- @opentripplanner/location-field now provides this functionality
otp-ui location field and geocoder refactor
Bring OTP-UI components, delete components/form components no longer used.
@evansiroky evansiroky changed the title otp-ui refactor new release: otp-ui refactor Jun 6, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #171 into master will decrease coverage by 0.33%.
The diff coverage is 5.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   11.37%   11.04%   -0.34%     
==========================================
  Files         133       91      -42     
  Lines        6145     3614    -2531     
  Branches     1778      968     -810     
==========================================
- Hits          699      399     -300     
+ Misses       4623     2802    -1821     
+ Partials      823      413     -410     
Impacted Files Coverage Δ
lib/actions/location.js 0.00% <0.00%> (ø)
lib/components/app/default-main-panel.js 0.00% <ø> (ø)
lib/components/app/print-layout.js 0.00% <0.00%> (ø)
lib/components/app/responsive-webapp.js 0.00% <0.00%> (ø)
lib/components/form/connected-location-field.js 0.00% <0.00%> (ø)
...mponents/form/connected-settings-selector-panel.js 0.00% <0.00%> (ø)
lib/components/form/date-time-modal.js 0.00% <0.00%> (ø)
lib/components/form/date-time-preview.js 0.00% <0.00%> (ø)
lib/components/form/default-search-form.js 0.00% <0.00%> (ø)
lib/components/form/plan-trip-button.js 0.00% <0.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e4630...c93a764. Read the comment docs.

@evansiroky evansiroky added the WIP Work in progress label Jun 6, 2020
@evansiroky
Copy link
Contributor Author

Has WIP label as it is waiting for a new release of otp-ui with opentripplanner/otp-ui#140 included.

@evansiroky evansiroky added BLOCKED Blocked (waiting on another PR to be merged) and removed WIP Work in progress labels Jun 9, 2020
@evansiroky evansiroky self-assigned this Jun 10, 2020
@evansiroky
Copy link
Contributor Author

Ready for review

@evansiroky evansiroky removed the BLOCKED Blocked (waiting on another PR to be merged) label Jun 12, 2020
@evansiroky evansiroky removed their assignment Jun 12, 2020
@binh-dam-ibigroup
Copy link
Collaborator

FYI @landonreed and @evansiroky : When testing, please update your map config as follows:

  baseLayers:
    - name: Streets
      url: //api.mapbox.com/styles/v1/mapbox/light-v10/tiles/{z}/{x}/{y}{retina}?access_token=...
      ...
      retina: "@2x"

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's roll it out!

@landonreed
Copy link
Member

@evansiroky, can we set the base branch to beta and have semantic release roll out a beta release?

@landonreed landonreed added the BLOCKED Blocked (waiting on another PR to be merged) label Jun 16, 2020
@binh-dam-ibigroup binh-dam-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Jul 1, 2020
@landonreed landonreed closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants