-
Notifications
You must be signed in to change notification settings - Fork 59
otp-ui location field and geocoder refactor #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- this only shows up when user data is stored and shown
- @opentripplanner/location-field now provides this functionality
Codecov Report
@@ Coverage Diff @@
## dev #137 +/- ##
======================================
Coverage ? 10.13%
======================================
Files ? 132
Lines ? 5861
Branches ? 1711
======================================
Hits ? 594
Misses ? 4469
Partials ? 798
Continue to review full report at Codecov.
|
|
@evansiroky, I believe the user settings overlay was a feature ;) |
landonreed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of UI tweaks are needed, I think:
|
IMO the UI tweak should be addressed as a separate issue. |
|
See commit pushed to resolve styling issues. See opentripplanner/otp-ui#89 for fixes to blurring of location-field. |
landonreed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, thanks for fixing the onBlur
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

This PR replaces the location field and geocoding functionality using code sourced from otp-ui.
Also, this code fixes an annoying bug that would overlay the UserSettings component on the welcome screen when user data persistence was active.