OTP-UI trip settings #141
Merged
OTP-UI trip settings #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `styled.js`. Extract UserTripS
…tp-ui-trip-settings
…electorPanel controls.
Bring OTP-UI components, delete components/form components no longer used.
Collaborator
Author
|
When did |
Codecov Report
@@ Coverage Diff @@
## dev #141 +/- ##
==========================================
+ Coverage 10.28% 10.88% +0.60%
==========================================
Files 131 127 -4
Lines 5777 5458 -319
Branches 1694 1587 -107
==========================================
Hits 594 594
+ Misses 4393 4130 -263
+ Partials 790 734 -56
Continue to review full report at Codecov.
|
evansiroky
approved these changes
Mar 20, 2020
landonreed
reviewed
Mar 30, 2020
landonreed
approved these changes
Mar 30, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
LGTM, only comment is adding jsdoc to the UserTripSettings component. Please do that before merging.
Member
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings components of OTP-UI trip-form package into OTP-react-redux.
The SettingsSelectorPanel and DateTimeSelector components have been replaced with their counterparts in OTP-UI. Form components that became unused have been removed.
The PR leaves only one thing out pending otp-ui PR 92. When you select an access mode (e.g. Transit + Bike), the title does not get bold (it was previously).