Add a component for the elevation point marker #152
Conversation
There was a problem hiding this comment.
See comments about comments. Also, did you test this? I tried it out and the marker doesn't actually move when the user hovers over the position on the leg diagram
see elevation-marker-not-moving.mov.zip (click link to download, then unzip to play video). Not sure if the issue is in elevation point marker or leg diagram.
|
@landonreed, @evansiroky is right about opentripplanner/otp-ui#107. To make this work, I am reverting the core-utils call to the old itinerary function with the corrected turlAlong syntax. |
…nction, with correct turfAlong
Codecov Report
@@ Coverage Diff @@
## dev #152 +/- ##
==========================================
- Coverage 13.02% 12.96% -0.06%
==========================================
Files 115 116 +1
Lines 4569 4588 +19
Branches 1321 1324 +3
==========================================
Hits 595 595
- Misses 3373 3389 +16
- Partials 601 604 +3
Continue to review full report at Codecov.
|
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
I'd prefer to make a release of otp-ui and update that dependency instead of adding a TODO.
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As a part of the map refactor we left out the elevation point marker display on the map. This PR adds it back in a new map component. This PR depends on opentripplanner/otp-ui#107 in order to work properly.