OTP-UI core-utils #157
Merged
OTP-UI core-utils #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathering the latest code before starting.
…rr with TriMetLegIcon.
…pentripplanner/core-utils count
…er/core-utils/query-params.
…i (except getTitle(state))
…tils/query (except getUiUrlPara
…planner/core-utils/itinerary.
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
reviewed
Apr 24, 2020
landonreed
requested changes
Apr 24, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
I think we can simplify the util files in this repo a little more. Also, we should maybe rethink the import style in some places for the coreUtils.
landonreed
approved these changes
Apr 28, 2020
Member
|
@binh-dam-ibigroup, could you fix the conflicts. Then we can go ahead with a merge. |
Collaborator
Author
|
Conflicts resolved. |
Member
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates code to use the OTP-UI core-utils package.
It also removes legacy user profile code.
(The PR does not include OTP-ui's icons.)
In this PR, we generalize this notation for most OTP-UI packages:
which removes the path to the lib folder in each OTP-UI package.