Skip to content

Conversation

@landonreed
Copy link
Member

@landonreed landonreed commented May 28, 2020

This PR conditionally adds the leaflet prop detectRetina, which is used to fetch different sized tiles. It was causing labels to appear very small in retina displays.

@landonreed landonreed changed the base branch from dev to master May 28, 2020 19:50
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 11.37%. Comparing base (88f94e1) to head (177a56e).
Report is 6727 commits behind head on master.

Files with missing lines Patch % Lines
lib/components/map/base-map.js 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   11.38%   11.37%   -0.01%     
==========================================
  Files         133      133              
  Lines        6142     6145       +3     
  Branches     1775     1778       +3     
==========================================
  Hits          699      699              
- Misses       4621     4623       +2     
- Partials      822      823       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@landonreed landonreed merged commit 58e4630 into master May 28, 2020
@landonreed landonreed deleted the fix-leaflet-retina branch May 28, 2020 21:21
@landonreed
Copy link
Member Author

🎉 This PR is included in version 0.13.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@binh-dam-ibigroup binh-dam-ibigroup added the ported-to-otp-ui Indicates whether changes made to the maintenance branch have been ported to otp-ui label Jul 2, 2020
@landonreed
Copy link
Member Author

🎉 This PR is included in version 1.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ported-to-otp-ui Indicates whether changes made to the maintenance branch have been ported to otp-ui released on @alpha released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants