React Intl Ramp Up PR #1 #430

binh-dam-ibigroup · 2021-08-16T19:01:11Z

This PR is a subset of the changes from the react-intl-ramp-up branch to facilitate reviews, and gathers commits for localization of components in the narrative subfolder.

…l-ramp-up

…tional components):

…er/otp-react-redux into react-intl-ramp-up

…ineraries & update ItinerarySum

evansiroky · 2021-08-17T02:16:03Z

i18n/en-US.yml

+        {issueNum, plural,
+          =0 {found}
+          one {(and {issueNum, number} issue) found}
+          other {(and {issueNum,number} issues) found}


Suggested change

other {(and {issueNum,number} issues) found}

other {(and {issueNum, number} issues) found}

addressed in ad8ea33

evansiroky · 2021-08-17T02:17:15Z

i18n/en-US.yml

+  SimpleRealtimeAnnotation:
+    usingRealtimeInfo: This trip uses real-time traffic and delay information
+  TabbedItineraries:
+    optionNumber: "Option {optionNum,number}"


Suggested change

optionNumber: "Option {optionNum,number}"

optionNumber: "Option {optionNum, number}"

addressed in ad8ea33

evansiroky · 2021-08-17T02:18:57Z

i18n/fr-FR.yml

+        {issueNum, plural,
+          =0 {trouvé}
+          one {(et {issueNum, number} problème) trouvé}
+          other {(and {issueNum,number} problèmes) trouvés}


Suggested change

other {(and {issueNum,number} problèmes) trouvés}

other {(and {issueNum, number} problèmes) trouvés}

addressed in ad8ea33

evansiroky · 2021-08-17T02:19:09Z

i18n/fr-FR.yml

+  SimpleRealtimeAnnotation:
+    usingRealtimeInfo: Ce trajet utilise les informations en temps réel sur le trafic et les retards
+  TabbedItineraries:
+    optionNumber: "Option {optionNum,number}"


Suggested change

optionNumber: "Option {optionNum,number}"

optionNumber: "Option {optionNum, number}"

addressed in ad8ea33

evansiroky · 2021-08-17T02:21:27Z

lib/components/narrative/default/format-duration.js

@@ -0,0 +1,17 @@
+import moment from 'moment-timezone'


Since this component is also used in other kinds of itineraries that aren't the default, this should live somewhere else, perhaps even in some common components folder.

I moved this and format-time to a components/util/ folder in later i18n-ramp-up commits (7600b0c)

moved here in ad8ea33

evansiroky · 2021-08-17T02:21:46Z

lib/components/narrative/default/format-time.js

@@ -0,0 +1,14 @@
+import moment from 'moment-timezone'


Since this component is also used in other kinds of itineraries that aren't the default, this should live somewhere else, perhaps even in some common components folder.

evansiroky · 2021-08-17T02:25:59Z

lib/components/narrative/default/default-itinerary.js

        <span>
-          <FormattedDuration duration={itinerary.walkTime} />{' '}
+          <FormattedDuration duration={itinerary.walkTime} />
+          {' '}


I think adding whitespace is a no-no when using internationalization. If this is for styling purposes to add padding or something, the styling should be changed instead.

I believe this is for formatting purposes (the white space between time and icon)

I'm not sure how to go about changing this via styling though, would it require a special LegIcon component?

Addressed in 8297d2e.

…bient locale.

binh-dam-ibigroup · 2021-09-03T15:30:39Z

Ready for review again @miles-grant-ibigroup, with one file moved (for icons) that touched quite a few components.

miles-grant-ibigroup

This all looks amazing thanks so much! But I would please merge dev into this branch before merging this PR. I think there will be some issues that arise even if the code merges correctly.

binh-dam-ibigroup · 2021-09-07T14:09:33Z

This all looks amazing thanks so much! But I would please merge dev into this branch before merging this PR. I think there will be some issues that arise even if the code merges correctly.

Merge with dev was done in 4299ee0.

github-actions · 2021-10-05T17:07:56Z

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

binh-dam-ibigroup and others added 21 commits July 6, 2021 19:16

refactor(i18n,TripTools): Extract localizable strings from component.

c52832f

refactor(i18n,narrative): Localize SimpleRealtimeAnnotation.

16bd6e6

chore(codespell): Don't codespell non-english string resources.

9770827

chore(codespell): Do not codespell French language files.

30cf4e6

Merge remote-tracking branch 'philip-cline/react-intl' into react-int…

83fadcf

…l-ramp-up

refactor(i18n,SaveTripButton): Localize SaveTripButton.

f6131d4

improvement(localize ItinerarySummary component & refactor a few func…

080a3e9

…tional components):

refactor(Linting):

f5cd8f1

Merge branch 'dev' into react-intl-ramp-up

2fcee4c

chore(i18n): Fix strings for ItinerarySummary.

2fc186d

refactor(i18n,RealtimeAnnotation): Extract strings for component.

0585227

improvement(Addressing PR comments):

c066839

improvement(Merge changes):

9a3c475

refactor(i18n,PlanFirstLastButtons): Localize component.

adeb243

improvement(localize narrative-itineraries-header):

8d7b2ac

Merge branch 'react-intl-ramp-up' of https://github.com/opentripplann…

a5b7bd1

…er/otp-react-redux into react-intl-ramp-up

improvement(address PR comments):

1fbee66

improvement(TabbedInteraries & ItinerarySummaries): Localize TabbedIt…

4bbbe49

…ineraries & update ItinerarySum

chore(i18n): Update language strings.

25c3001

Merge branch 'dev' into react-intl-ramp-up-pr1

1041533

refactor: Fix lint

1883b3c

binh-dam-ibigroup requested a review from evansiroky August 16, 2021 19:30

binh-dam-ibigroup assigned evansiroky Aug 16, 2021

evansiroky reviewed Aug 17, 2021

View reviewed changes

miles-grant-ibigroup assigned binh-dam-ibigroup and unassigned miles-grant-ibigroup Aug 27, 2021

binh-dam-ibigroup added 13 commits September 2, 2021 13:26

refactor: Address PR comments

7054a36

refactor(util/Icon): Add withSpace prop

278c980

refactor(narrative/icon): Remove in favor of components/util/icon.

a629c47

fix(TripSummary): Remove green bar outside of batch itinerary results.

8e014aa

refactor(FormattedTimeRange): Format time using default format for am…

b07e031

…bient locale.

refactor(FormattedDuration): Make default export, rename file.

0f4a3c9

refactor(util/icon): Make tests pass.

a0c2b52

test(StopViewer): Update snapshots, still.

ea5305f

Merge branch 'dev' into react-intl-ramp-up-pr1

4299ee0

refactor(admin/trip-status): Remove unused import.

e399f4d

refactor(FieldTripStatusIcon): Fix import

7ef85a4

refactor(RealtimeAnnotation): Improve rich text rendering.

149b464

refactor(TabbedItineraries): Replace <br/>s with block <span>s.

42fec94

binh-dam-ibigroup requested a review from miles-grant-ibigroup September 3, 2021 15:29

binh-dam-ibigroup assigned miles-grant-ibigroup and unassigned binh-dam-ibigroup Sep 3, 2021

miles-grant-ibigroup approved these changes Sep 7, 2021

View reviewed changes

miles-grant-ibigroup assigned binh-dam-ibigroup and unassigned miles-grant-ibigroup Sep 7, 2021

Merge branch 'dev' into react-intl-ramp-up-pr1

88c7e2b

binh-dam-ibigroup merged commit b1d6b92 into dev Sep 10, 2021

binh-dam-ibigroup deleted the react-intl-ramp-up-pr1 branch September 10, 2021 14:07

miles-grant-ibigroup mentioned this pull request Oct 5, 2021

Release: October 5, 2021 #463

Merged

github-actions bot added the released label Oct 5, 2021

binh-dam-ibigroup mentioned this pull request Jun 22, 2022

add support multi-language #115

Closed

	other {(and {issueNum,number} issues) found}
	other {(and {issueNum, number} issues) found}

	optionNumber: "Option {optionNum,number}"
	optionNumber: "Option {optionNum, number}"

	other {(and {issueNum,number} problèmes) trouvés}
	other {(and {issueNum, number} problèmes) trouvés}

React Intl Ramp Up PR #1 #430

React Intl Ramp Up PR #1 #430

Uh oh!

Conversation

binh-dam-ibigroup commented Aug 16, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philip-cline Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

binh-dam-ibigroup commented Sep 3, 2021

Uh oh!

miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

binh-dam-ibigroup commented Sep 7, 2021

Uh oh!

github-actions bot commented Oct 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

philip-cline Aug 18, 2021 •

edited

Loading