UCT/IB: Cache RoCE network interface index per sys_dev#11230
Merged
tvegas1 merged 2 commits intoopenucx:masterfrom Mar 4, 2026
Merged
UCT/IB: Cache RoCE network interface index per sys_dev#11230tvegas1 merged 2 commits intoopenucx:masterfrom
tvegas1 merged 2 commits intoopenucx:masterfrom
Conversation
yosefe
reviewed
Mar 3, 2026
| uint8_t gid_index, unsigned *ndev_index_p) | ||
| { | ||
| uct_ib_device_to_ndev_key_t ib_dev = {.guid = IBV_DEV_ATTR(dev, node_guid), | ||
| uct_ib_device_to_ndev_key_t ib_dev = {.sys_dev = dev->sys_dev, |
Member
There was a problem hiding this comment.
maybe we can use the uint32_t built-in hash since can now pack the smaller hash key to uint32
yosefe
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Cache RoCE network interface index per sys_dev.
Why?
Some IB device to network interface index resolutions can fail, because different HCAs can have identical
node_guid.How?
Replace by
sys_devas thenode_guidis only used in the caching key, not for actual network interface index lookup.