Skip to content

UCS/RCACHE/TEST: Fix 'status' variable override in rcache error flow#4025

Merged
yosefe merged 2 commits intoopenucx:masterfrom
yosefe:topic/rcache-fix-error-flow
Aug 8, 2019
Merged

UCS/RCACHE/TEST: Fix 'status' variable override in rcache error flow#4025
yosefe merged 2 commits intoopenucx:masterfrom
yosefe:topic/rcache-fix-error-flow

Conversation

@yosefe
Copy link
Copy Markdown
Contributor

@yosefe yosefe commented Aug 7, 2019

Fixes #4016
Issue introduced by #3939

This PR also adds event checks to UCM, so the rcache unit test will fail to create the rcache.

yosefe added 2 commits August 7, 2019 17:23
- In BISTRO mode, expect to get all events (not just any hook called)
- Return Invalid Parameter for non-existing events
@swx-jenkins1
Copy link
Copy Markdown

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/8599/ for details.

@mellanox-github
Copy link
Copy Markdown
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/11766/ for details (Mellanox internal link).

@mellanox-github
Copy link
Copy Markdown
Contributor

Mellanox CI: PASSED on 29 workers (click for details)

Note: the logs will be deleted after 14-Aug-2019

Agent/Stage Status
_main ✔️ SUCCESS
hpc-arm-cavium-jenkins_W0 ✔️ SUCCESS
hpc-arm-cavium-jenkins_W1 ✔️ SUCCESS
hpc-arm-cavium-jenkins_W2 ✔️ SUCCESS
hpc-arm-cavium-jenkins_W3 ✔️ SUCCESS
hpc-arm-hwi-jenkins_W0 ✔️ SUCCESS
hpc-arm-hwi-jenkins_W1 ✔️ SUCCESS
hpc-arm-hwi-jenkins_W2 ✔️ SUCCESS
hpc-arm-hwi-jenkins_W3 ✔️ SUCCESS
hpc-test-althca_W0 ✔️ SUCCESS
hpc-test-althca_W1 ✔️ SUCCESS
hpc-test-althca_W2 ✔️ SUCCESS
hpc-test-althca_W3 ✔️ SUCCESS
hpc-test-node-gpu_W0 ✔️ SUCCESS
hpc-test-node-gpu_W1 ✔️ SUCCESS
hpc-test-node-gpu_W2 ✔️ SUCCESS
hpc-test-node-gpu_W3 ✔️ SUCCESS
hpc-test-node-legacy_W0 ✔️ SUCCESS
hpc-test-node-legacy_W1 ✔️ SUCCESS
hpc-test-node-legacy_W2 ✔️ SUCCESS
hpc-test-node-legacy_W3 ✔️ SUCCESS
hpc-test-node-new_W0 ✔️ SUCCESS
hpc-test-node-new_W1 ✔️ SUCCESS
hpc-test-node-new_W2 ✔️ SUCCESS
hpc-test-node-new_W3 ✔️ SUCCESS
r-vmb-ppc-jenkins_W0 ✔️ SUCCESS
r-vmb-ppc-jenkins_W1 ✔️ SUCCESS
r-vmb-ppc-jenkins_W2 ✔️ SUCCESS
r-vmb-ppc-jenkins_W3 ✔️ SUCCESS

@yosefe
Copy link
Copy Markdown
Contributor Author

yosefe commented Aug 7, 2019

@hoopoepg @hiroyuki-sato can you pls take a look?

Copy link
Copy Markdown
Contributor

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@yosefe
Copy link
Copy Markdown
Contributor Author

yosefe commented Aug 8, 2019

bot:pipe:retest

@yosefe yosefe merged commit 0815086 into openucx:master Aug 8, 2019
@yosefe yosefe deleted the topic/rcache-fix-error-flow branch August 8, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UCX WARN : destroying inuse region, and heap corruption

5 participants