-
Notifications
You must be signed in to change notification settings - Fork 219
Switch shiki for prism #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch shiki for prism #1169
Conversation
This fixes WebIDL warnings
mfreed7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me, but I'm definitely not an expert in this area. I'll click Approve, but it'd be good to get someone more authoritative to review, maybe?
|
@lukewarlow would you be ok if I add the |
|
Feel free to! The theme was picked somewhat at random iirc. |
|
Great, have just PR'ed it towards your PR, hope that works? |
Use accessible color scheme, support forced colors
|
Merged your PR into my PR branch. |
|
I'm somewhat supportive of this change, as I'm more familiar with Prism, but I'm not sure this really fixed #1169: it doesn't warn that |
|
Hmm it did support webidl? Perhaps Hidde's CSS changed that to some extent I can spend some time to look into that. |
|
It should not have affected webidl (improved or worsened) as no selectors were changed, except for a few forced colors related ones. Will look into it today. |
|
I may be looking in the wrong places, but when I compare instances of webidl on our site currently to in this PR, I see them rendered as plain text in the current site and as syntax highlighted in this PR?
|
|
Yup looks correct to me. I'm assuming Keith looked locally and didn't install something correctly? |
|
I do not see a package update in our PR, does |
|
Yeah astro supports both out of the box. |
|
Hm, that’s weird. I see the highlights now, whereas yesterday I swear I couldn’t. In that case let’s merge this! |
This fixes WebIDL warnings
Fixes #693