Changing verification clients - #113
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the verification repo’s SDSP-related steps and scenarios to match the updated Flight Blender API/client naming (aligning with openutm/flight-blender#85), primarily by renaming the SDSP session identifier argument.
Changes:
- Renamed SDSP step argument
session_id→surveillance_session_idacross the FlightBlender client step methods. - Updated YAML scenarios and scenario documentation to use the new argument name.
- Updated unit tests to call/assert the new keyword argument.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_client_steps.py | Updates SDSP-related test calls/assertions to use surveillance_session_id. |
| src/openutm_verification/core/clients/flight_blender/flight_blender_client.py | Renames SDSP session parameter in step methods and websocket initializers to surveillance_session_id. |
| scenarios/sdsp-f3623/verify_sdsp_metrics.yaml | Updates Start/Stop SDSP Session arguments to surveillance_session_id. |
| scenarios/sdsp-f3623/sdsp_track.yaml | Updates SDSP Track scenario arguments to surveillance_session_id. |
| scenarios/sdsp-f3623/sdsp_heartbeat.yaml | Updates SDSP Heartbeat scenario arguments to surveillance_session_id. |
| scenarios/README.md | Updates documented YAML examples to use surveillance_session_id. |
Comments suppressed due to low confidence (1)
src/openutm_verification/core/clients/flight_blender/flight_blender_client.py:1161
- The docstring for
start_stop_sdsp_sessionis now out of sync with the function signature/behavior: it still refers tosession_id(and mentions validating it), and theReturns:section saysbooleven though the step returns a message string (wrapped intoStepResultby@scenario_step). Update the docstring to usesurveillance_session_idand describe the actual return value (or adjust the implementation/type hints if the intention is to return a boolean).
async def start_stop_sdsp_session(self, surveillance_session_id: str, action: SDSPSessionAction) -> str:
"""
Starts or stops an SDSP (Strategic Deconfliction Service Provider) session based on the specified action.
This method interacts with the Flight Blender service to manage the lifecycle of an SDSP session.
It can be used to initiate a new session or terminate an existing one.
Args:
session_id (str): The unique identifier of the SDSP session to start or stop.
action (SDSPSessionAction): The action to perform on the session, such as START or STOP.
Returns:
bool: True if the action was successfully performed, False otherwise.
Raises:
ValueError: If the session_id is invalid or the action is not supported.
ConnectionError: If there is an issue communicating with the Flight Blender service.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
atti92
self-requested a review
March 30, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the verification repo to accommodate changes proposed at: openutm/flight-blender#85