Skip to content

Typechecks and test fixes#35

Merged
iskandr merged 2 commits intomasterfrom
typechecks-and-test-fixes
Mar 10, 2015
Merged

Typechecks and test fixes#35
iskandr merged 2 commits intomasterfrom
typechecks-and-test-fixes

Conversation

@timodonnell
Copy link
Copy Markdown
Contributor

  • Replace reference to pyensembl type_checks module with typechecks package
  • Fix nondeterministic test failure in test_vcf.py
  • Add test utility module (__init__.py in the test directory) with data_path function for getting the absolute path to test resources
  • Modify tests to use data_path, instead of assuming that the current working directory is the 'test' directory. This makes it possible to run nosetests either in the root varcode directory or in the test directory.

Review on Reviewable

 * Fix nondeterministic test failure in test_vcf.py
 * Add module with `data_path` test utility function for getting the absolute path to test resources
 * Modify tests to use `data_path`, instead of assuming that the current working directory is the 'test' directory. This makes it possible to run `nosetests` either in the root `varcode` directory or in the `test` directory.
@iskandr
Copy link
Copy Markdown
Contributor

iskandr commented Mar 10, 2015

LGTM

iskandr added a commit that referenced this pull request Mar 10, 2015
@iskandr iskandr merged commit 7d9ca0d into master Mar 10, 2015
@iskandr iskandr deleted the typechecks-and-test-fixes branch March 10, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants