Skip to content

Refactor coding effect#55

Merged
iskandr merged 21 commits intomasterfrom
refactor-coding-effect
Apr 6, 2015
Merged

Refactor coding effect#55
iskandr merged 21 commits intomasterfrom
refactor-coding-effect

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Apr 6, 2015

  • Simplified some of the spaghetti logic from coding_effect by splitting it into frameshift_coding_effect and in_frame_coding_effect
  • Added ExonicSpliceSite annotations (purine change at start of exon, "MAG" pattern change at end of exon), which carry alternate coding effects
  • Added unit tests for more classes of effects

Review on Reviewable

Comment thread varcode/effects.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a format specifier?

@timodonnell
Copy link
Copy Markdown
Contributor

LGTM

iskandr added a commit that referenced this pull request Apr 6, 2015
@iskandr iskandr merged commit 398416e into master Apr 6, 2015
@iskandr iskandr deleted the refactor-coding-effect branch April 6, 2015 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants