Merged
Conversation
Unit tests run for me on both Python 3.4 and 2.7.
Contributor
There was a problem hiding this comment.
Why did the actual calls to the test function come out of the loop?
Contributor
Author
There was a problem hiding this comment.
yikes -- good catch. there was some tab / space issue that i was trying to correct here, but got it wrong. fixed.
Contributor
|
Other than the indent change in the main section of a test and the lack of |
* fix test_dbnsfp_validation.py indent issue introduced in previous commit * add future imports so code running in python 2 has closer semantics to python 3: print_function, division, absolute_import, unicode_literals * drop an unnecessary list() call in maf.py
Contributor
Author
|
PR updated to address comments |
Removed unnecessary "unicode_literals" from __future__ imports. Future imports are now: print_function, division, absolute_import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests run for me on both Python 3.4 and 2.7.