build.sh debug build fixes#338
Merged
Merged
Conversation
…specified in build.sh Using 'Debug' as build-type string Added linker options so that debug builds will preserve symbols Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
harrism
approved these changes
Nov 17, 2025
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
This looks good. The root cause indeed seems to have been case/capitalization. Surprised cmake doesn't auto-add -g to linker line for debug builds. Have you verified it does not?
…hese build types Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are proposed changes which fixes #337. Primarily this is to make sure the flags we specify for debug builds are passed through to the compiler correctly when using
build.shand that debug symbols and line numbers are being preserved by the linker. The name of the build I changed to 'Debug' because cmake is case sensitive and I wanted to be consistent with CMake 'typical values'