Debug build gtest fix#344
Merged
Merged
Conversation
…ds to get around numerical differences between cached results built with release and debug build tests Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts test tolerances in the GaussianProjectionForward tests to account for numerical differences between debug and release builds. The changes address issue #86 where cached test results generated with release builds were failing when tests were run with debug builds.
- Fixes the
DISABLED_GenerateOutputDatatest to usetorch::log(scales)instead ofscales, making it consistent with the active tests - Introduces conditional compilation (
#ifdef NDEBUG) to use stricter tolerances for release builds and relaxed tolerances for debug builds - Uses appropriate tolerance values for different data types (floating-point values vs. integer radii)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the tolerances in the GaussianProjectionForward gtest for debug builds to get around numerical differences between cached results built with release and debug build test outputs. fixes #86
Signed-off-by: Jonathan Swartz jonathan@jswartz.info