Fix the derivation of the number of cameras in the rasterization kernels that would be incorrect when in packed mode.#412
Merged
Conversation
…els that would be incorrect when in packed mode. Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
harrism
approved these changes
Jan 14, 2026
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, and adding those tests is a big improvement in coverage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the value for the number of cameras was being incorrectly taken from the batch dimension of
means2dbut when in packed mode, this would be the number of gaussians, not the number of cameras. Fixed up this logic, made comments about dimensions more complete and added some tests.Signed-off-by: Jonathan Swartz jonathan@jswartz.info