Fix crash loading GaussianPly files to CPU device#417
Merged
Conversation
Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
swahtz
added
the
Gaussian Splatting
harrism
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when loading a GaussianSplat3d from a ply I was getting a sporadic crash (though more often then not it did crash). This happens when loading a ply file to the cpu device. The tensors we make from the
PlyDatadon't own the buffers and when the load function returns, the PlyData goes out of scope. This PR addresses this by taking a clone of the Tensor before other operations so even if the Tensors aren't move to the GPU (where a copy of that data would have happened masking the issue on GPU devices), the buffers remain valid on the CPU.