Implement PrivateUse1 (multiGPU) support for MCMC kernels#421
Merged
Conversation
harrism
requested review from
blackencino,
matthewdcong and
phapalova
and removed request for
phapalova
harrism
added
core library
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
harrism
force-pushed
the
feature/mcmc-multigpu-support
branch
from
cc6eb32 to
d8722db
Compare
Contributor
|
looks good pending the CI fix |
matthewdcong
approved these changes
Jan 22, 2026
Contributor
|
CI fix is merged so if you grab the latest the tests should pass now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiGPU dispatch for GaussianMCMCAddNoise and GaussianRelocation operations to enable unified memory multiGPU backend support.
Both implementations follow the established PrivateUse1 pattern:
Updated test to remove PrivateUse1 NOT_IMPLEMENTED check, matching the pattern used by other operations in the codebase.
Closes #393
Signed off by Mark Harris mharris@nvidia.com
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com