Disable two GCC 13.3 warnings#439
Merged
Merged
Conversation
Signed-off-by: Matthew Cong <mcong@nvidia.com>
matthewdcong
force-pushed
the
disable_gcc13_warnings
branch
from
1fd5aa3 to
181a21a
Compare
harrism
reviewed
Feb 3, 2026
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Do we really want to disable these warnings everywhere? Can you localize it to the problematic files or lines?
The pytorch issue was for something different, they added -Wno-error=nonnull, specifically for a test target.
Contributor
Author
|
I tried to localize it but wasn't able to find a solution. It doesn't work to surround the header because the actual ordering could be different due to transitive includes. Furthermore, surrounding the function doesn't work either. I even tried converting it to a tuple instead of a vector at the top level but that doesn't work either 😞 |
Contributor
Author
|
It's not the same error, but a similar one, also occurring in |
harrism
approved these changes
Feb 3, 2026
Contributor
|
OK, I'll approve. |
harrism
added a commit
to harrism/fvdb-core
that referenced
this pull request
Mar 12, 2026
gcc-toolset-14 (GCC 14.2.1) triggers a false -Wmaybe-uninitialized warning in NanoVDB's HDDA.h. This is a known class of GCC false positive (76+ open bugs in GCC bugzilla). Suppress it for both CXX and CUDA host compiler, matching the precedent from openvdb#439. Signed-off-by: Mark Harris <mharris@nvidia.com>
swahtz
pushed a commit
that referenced
this pull request
Mar 25, 2026
gcc-toolset-14 (GCC 14.2.1) triggers a false -Wmaybe-uninitialized warning in NanoVDB's HDDA.h. This is a known class of GCC false positive (76+ open bugs in GCC bugzilla). Suppress it for both CXX and CUDA host compiler, matching the precedent from #439. Signed-off-by: Mark Harris <mharris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13.3 doesn't correctly statically analyze the PyTorch compile-time logic for autograd (i.e. counting the number of
Variablesreturned from the forward pass) and throw what I believe to be erroneousWarray-boundsandWstringop-overflowwarnings. These are in particular associated with theVolumeRenderfunction and its forward pass which unlike most returns avectorof tensors rather than a single one.PyTorch encountered a similar error in pytorch/pytorch#137092 and disabled the warning.