Build speedups, added trace and optional pip forced install#443
Merged
blackencino merged 6 commits intoFeb 4, 2026
Merged
Conversation
…ssors Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
matthewdcong
requested changes
Feb 4, 2026
Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
harrism
requested review from
Copilot
and removed request for
fwilliams and
harrism
Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build.sh script to reduce rebuild stalls in WSL-like environments and to add additional build-script modifiers for debugging and reinstall behavior.
Changes:
- Add optional PATH sanitization (filtering
/mnt/*) when a WSL-like environment is detected, and runpip/cmakevia a wrapper. - Add a
tracemodifier to enable verbose CMake trace output. - Add a
cleanmodifier that toggles whetherpip installuses--force-reinstall, and add CUDA discovery hints viaCUDA_HOME/CMake defines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Christopher Horvath <chorvath@nvidia.com>
Contributor
Author
|
I addressed all of @matthewdcong , @harrism , and Copilot's change requests. All fixed. |
matthewdcong
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the build script to improve rebuild times and address reviewer feedback.
Path sanitization for virtualized environments:
/mnt/*paths via 9P protocol)/media/sf_*paths via vboxsf)/mnt/hgfs/*paths via vmhgfs-fuse)Build behavior improvements:
--force-reinstallfor the install target to ensure freshly built packages are installed even when the version number matches. The--no-depsflag ensures this only affects fvdb-core itself, not dependencies like torch.cleanflag (now redundant since--force-reinstallis always used)CUDA_HOMEautomatically in Conda environments; in venv environments, leave it unset to avoid version mismatches with PyTorch's rpathed CUDA librariesNew option:
traceoption for CMake debugging (very verbose). Can be combined with other options:./build.sh install trace verbose gtests