Fix: ProjectionForward initializes accessors in both the initializer list and constructor body#450
Merged
Conversation
… in both the initializer list and the body of the constructor Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a constructor issue in the Gaussian splatting projection forward op (ProjectionForward) where several tensor accessors were being initialized twice (once in the initializer list and again in the constructor body), which is redundant and potentially error-prone.
Changes:
- Removed duplicate accessor assignments from the
ProjectionForwardconstructor body. - Kept accessor initialization solely in the constructor initializer list for
means,quats,logScales,worldToCamMatrices, andprojectionMatrices.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swahtz
added
the
Gaussian Splatting
harrism
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix initializing the means, quats, scales, etc. accessors initialized in both the initializer list and the body of the constructor