Fix smoke test Python setup and open release PR as draft#528
Merged
Conversation
- Use actions/setup-python@v5 in smoke test validation containers instead of bare apt install. The nvidia/cuda Ubuntu 22.04 containers only have Python 3.10 in default repos; 3.12 and 3.13 need the deadsnakes PPA. This matches the approach used by the build job. - Open the release PR as a draft to avoid CI failures from the expected pyproject.toml version conflict between release branch and main. finish-release.sh marks it ready before merging. Signed-off-by: Mark Harris <mharris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
actions/setup-python@v5in smoke test validation containers instead ofbare
apt install. Thenvidia/cudaUbuntu 22.04 containers only havePython 3.10 in their default apt repos; Python 3.12 and 3.13 require the
deadsnakes PPA. This matches the approach already used by the build job.
Open the release PR as a draft to avoid CI failures from the expected
pyproject.tomlversion conflict between the release branch andmain.finish-release.shmarks it ready before merging.Test plan
start-release.shafter merge; verify smoke tests pass for allPython versions (3.10-3.13)
finish-release.shmarks the PR ready before merging