Make start-release.sh idempotent for safe re-runs#529
Merged
Conversation
Each step now checks whether it has already been completed: - Release branch: reuse if it already exists locally - Version on release branch: skip commit if already correct - Dev version bump on main: skip commit if already correct - PR creation: skip if an open release PR already exists This allows safely re-running the script after a partial failure or after fixing an issue discovered during the release process. Signed-off-by: Mark Harris <mharris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start-release.shidempotent so it can be safely re-run after a partialfailure or after fixing an issue discovered during the release process
correct state preserved)
Test plan
./devtools/test-release-scripts.shpasses (28/28)start-release.shtwice in a row -- second run shouldsucceed and detect existing state