Added nanovdb-editor as an optional dependency#559
Merged
Conversation
Also added a compatibility matrix of software similar to PyTorch (https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix) Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
swahtz
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates fVDB’s installation documentation to better communicate supported platform/software combinations per release, and extends Python packaging metadata with an install-time optional dependency for the visualization/viewer functionality.
Changes:
- Added a
vieweroptional dependency group to the Python package metadata (pyproject.toml) to installnanovdb-editoronly when needed. - Replaced the prior single-row requirements table in
docs/installation.rstwith a per-minor-release compatibility matrix (PyTorch/Python/CUDA/Vulkan).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pyproject.toml |
Introduces a viewer optional dependency extra for nanovdb-editor. |
docs/installation.rst |
Adds a compatibility matrix and clarifies supported software versions per fVDB minor release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
phapalova
approved these changes
Mar 24, 2026
Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
swahtz
added a commit
that referenced
this pull request
Mar 25, 2026
This pull request updates the documentation and package configuration to clarify supported software versions and add an optional dependency for the viewer feature. **Documentation updates:** * Updated the software requirements section in `docs/installation.rst` to include a compatibility matrix that specifies supported versions of fVDB alongside compatible versions of PyTorch, Python, CUDA, and Vulkan for each minor release. This provides clearer guidance for users on which software versions are officially supported. **Packaging improvements:** * Added an optional dependency group `viewer` in `pyproject.toml` for the `nanovdb-editor` package, allowing users to install viewer-related dependencies only when needed. --------- Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and package configuration to clarify supported software versions and add an optional dependency for the viewer feature.
Documentation updates:
docs/installation.rstto include a compatibility matrix that specifies supported versions of fVDB alongside compatible versions of PyTorch, Python, CUDA, and Vulkan for each minor release. This provides clearer guidance for users on which software versions are officially supported.Packaging improvements:
viewerinpyproject.tomlfor thenanovdb-editorpackage, allowing users to install viewer-related dependencies only when needed.