Fix additional sync point introduced in autograd change#599
Merged
Conversation
Signed-off-by: Matthew Cong <mcong@nvidia.com>
matthewdcong
force-pushed
the
fix_added_sync_point
branch
from
5d9ff2b to
637158c
Compare
harrism
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to #594 ,
torch::linalg::inv_exwas called to obtain the camera to world matrices. #594 switched to the Pythontorch.linalg.invinstead which is equivalent, but introduces a host-device synchronization. Revert this to usinginv_exto recover the prior behavior w/o the sync and recover performance.