Disambiguate CI job names and fix Torch CMake header path#635
Merged
Conversation
Add environment qualifiers (Conda, pip CUDA 12.8, pip CUDA 13.0) to all workflow and job names so each check is uniquely identifiable in GitHub branch protection rules. Standardize "PyTests" / "Unit Tests" naming inconsistency across workflows. Mark Torch include directories as SYSTEM to fix include pathing in pip builds. Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
swahtz
added
CI
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to (1) make GitHub Actions checks uniquely identifiable by adding environment qualifiers to workflow/job names, and (2) adjust Torch include handling in CMake to address pip-build header/include behavior.
Changes:
- Renamed CI workflows/jobs to include environment qualifiers: Conda, pip CUDA 12.8, pip CUDA 13.0.
- Standardized “PyTests” → “Unit Tests” naming in pip CUDA workflows.
- Updated CMake to add Torch include directories as
SYSTEMincludes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/CMakeLists.txt |
Changes how Torch include dirs are applied to the fvdb target (now SYSTEM and added via a separate call). |
.github/workflows/tests.yml |
Renames the Conda PR workflow and its jobs to include “(Conda)” qualifiers. |
.github/workflows/cu128.yml |
Renames the pip CUDA 12.8 PR workflow and its jobs to include “(pip CUDA 12.8)” qualifiers and “Unit Tests”. |
.github/workflows/cu130.yml |
Renames the pip CUDA 13.0 PR workflow and its jobs to include “(pip CUDA 13.0)” qualifiers and “Unit Tests”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harrism
approved these changes
Apr 21, 2026
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Looks good, modulo copilot comments.
…talls TORCH_INCLUDE_DIRS was added as a bare PUBLIC include, which baked build-machine absolute paths into the exported fvdb::fvdb target. Since fvdbConfig.cmake.in already appends the consumer's Torch paths at find_package time, exporting them is both redundant and breaks relocatability. Wrap each path individually in BUILD_INTERFACE via a foreach loop (a single generator expression mishandles the semicolon-separated list, which caused the path-mangling bug in Docker/pip builds). Signed-off-by: Jonathan Swartz <jonathan@jswartz.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add environment qualifiers (Conda, pip CUDA 12.8, pip CUDA 13.0) to all workflow and job names so each check is uniquely identifiable in GitHub branch protection rules. Standardize "PyTests" / "Unit Tests" naming inconsistency across workflows.
Mark Torch include directories as SYSTEM to fix include pathing in pip builds.