CODEOWNERS: require NVIDIA maintainer review for governance/CI files#676
Merged
Conversation
Split CODEOWNERS so that any maintainer (fvdb-dev) reviews code by default, while governance, legal, and CI/CD infrastructure require an NVIDIA maintainer (fvdb-dev-nvidia). The added patterns match files even before they exist, preventing a non-NVIDIA contributor from introducing them without NVIDIA approval. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CODEOWNERS to enforce a two-tier review model: general code can be reviewed by any maintainer team member, while governance/legal/CI infrastructure files require review from an NVIDIA maintainer team.
Changes:
- Clarifies CODEOWNERS precedence and cross-repo consistency in header comments.
- Keeps
@openvdb/fvdb-devas the default owner for all files. - Adds explicit, higher-precedence ownership rules for governance/legal/CI-related paths requiring
@openvdb/fvdb-dev-nvidiareview.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swahtz
approved these changes
Jul 1, 2026
Address review feedback on the governance docs: - MAINTAINERS.md: heading "Committers" -> "Maintainers" for consistency with the body. - CONTRIBUTING.md: fix broken in-page link (#committer -> #maintainer); point the broken local tsc/ CLA link to the canonical AcademySoftwareFoundation/openvdb TSC directory; "name and email is added" -> "are added". - CODE_OF_CONDUCT.md: point the broken local tsc/charter.md link to the canonical openvdb charter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
- CODE_OF_CONDUCT.md: add a heading and wrap the text; point the charter link to the current PDF location (the openvdb tsc/charter.md is now just a redirect stub). - MAINTAINERS.md: add trailing pipes / align the maintainer table for robust Markdown rendering. - CODEOWNERS: update the doc link from the legacy help.github.com URL to docs.github.com. - CONTRIBUTING.md: tidy spacing around the CLA parenthetical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
AGENTS.md requires commits to be both DCO-signed off (-s) and cryptographically signed (-S). CONTRIBUTING previously documented only the DCO sign-off, which could mislead contributors; add a "Signed Commits" note covering the signing requirement. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split
CODEOWNERSinto two review tiers:@openvdb/fvdb-dev) — any maintainer may review code.@openvdb/fvdb-dev-nvidia(child team offvdb-dev) — required for governance, legal, and CI/CD infrastructure:.github/,CODEOWNERS,LICENSE,MAINTAINERS.md,CODE_OF_CONDUCT.md,CONTRIBUTING.md,SECURITY.md,.gitmodules.Why
Certain files (legal, governance, release/CI automation) should require sign-off from an NVIDIA maintainer. The listed patterns match files even before they exist, so a non-NVIDIA contributor cannot introduce e.g. a
MAINTAINERS.mdorSECURITY.mdwithout NVIDIA approval.This
CODEOWNERSis kept identical acrossfvdb-core,fvdb-reality-capture, andfvdb-examples.Note for reviewers
For enforcement, each repo's branch protection must have "Require review from Code Owners" enabled, and
fvdb-dev-nvidiamust have explicit write access to the repo (child-team status does not inherit repo access).🤖 Generated with Claude Code