Skip to content

Make HeatingDevice inherit from Device - #356

Merged
woehrl01 merged 6 commits into
openviess:masterfrom
CFenner:heatingDevice
Apr 2, 2024
Merged

Make HeatingDevice inherit from Device#356
woehrl01 merged 6 commits into
openviess:masterfrom
CFenner:heatingDevice

Conversation

@CFenner

@CFenner CFenner commented Jan 21, 2024

Copy link
Copy Markdown
Member

This makes Device the common base class also for HeatingDevices.

Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated
Comment thread tests/test_VitochargeVX3.py Outdated

@Nibot1 Nibot1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@woehrl01
woehrl01 merged commit ffcd5e2 into openviess:master Apr 2, 2024
@CFenner CFenner added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants