feat: preliminary docs on STARK backend scope/support#16
Merged
Conversation
yi-sun
approved these changes
May 13, 2024
Collaborator
yi-sun
left a comment
yi-sun
left a comment
There was a problem hiding this comment.
LGTM, but once the API stabilizes, would be helpful to associate these operations to the functions in code.
jonathanpwang
added a commit
that referenced
this pull request
May 16, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
jonathanpwang
added a commit
that referenced
this pull request
May 17, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * test: added ListChip and a test involving RangeCheckerChip and ListChip * chore: changed to using determinstic seed * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * test: testing thread safety and other improvements * test: testing thread safety and other improvements * test: generating traces in parallel * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * test: testing RangeCheckerChip * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: added XorChip * chore: small fix * feat: add indexless cached lookup test for partitioned Air with interactions * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * feat: added relative indexing and some documentation * wip * chore: simplifying trace.rs * chore: rename crates `afs-stark-backend, afs-derive` - `afs-middleware` -> `afs-stark-backend` - `afs-middleware-derive` -> `afs-derive` Imports can be handled by global find/replace. * chore: fix github workflow * chore: fix workflow name * chore: set up concurrency for workflow * chore: added test-utils crate * chore: removing the xor chip * wip * chore: moving the tests to a tests/ directory in test-utils crate * chore: fixing imports and moving cached_lookup to stark-backend --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
jonathanpwang
added a commit
that referenced
this pull request
May 27, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` * feat: add instrumented hash/compress * chore: return instrument counters since fields are private * feat: prelim verifier instrumentation * feat: full benchmark writing to csv * chore: turn off instrumenting during proving * fix: instrument not properly on * fix: flush writer * chore: clean up config module * chore(chips): remove old test config module * feat: add `StarkEngine` for convenience * feat: add cached_lookup prover benchmark * fix: p3-maybe-rayon `parallel` feature was not on (#28) * fix: p3-maybe-rayon `parallel` feature was not on feature is `parallel` not `rayon` * chore: simplify code --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * test: added ListChip and a test involving RangeCheckerChip and ListChip * chore: changed to using determinstic seed * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * test: testing thread safety and other improvements * test: testing thread safety and other improvements * test: generating traces in parallel * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * test: testing RangeCheckerChip * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: added XorChip * chore: small fix * feat: add indexless cached lookup test for partitioned Air with interactions * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * feat: added relative indexing and some documentation * wip * chore: simplifying trace.rs * chore: rename crates `afs-stark-backend, afs-derive` - `afs-middleware` -> `afs-stark-backend` - `afs-middleware-derive` -> `afs-derive` Imports can be handled by global find/replace. * chore: fix github workflow * chore: fix workflow name * chore: set up concurrency for workflow * chore: added test-utils crate * chore: removing the xor chip * wip * chore: moving the tests to a tests/ directory in test-utils crate * chore: fixing imports and moving cached_lookup to stark-backend --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` * feat: add instrumented hash/compress * chore: return instrument counters since fields are private * feat: prelim verifier instrumentation * feat: full benchmark writing to csv * chore: turn off instrumenting during proving * fix: instrument not properly on * fix: flush writer * chore: clean up config module * chore(chips): remove old test config module * feat: add `StarkEngine` for convenience * feat: add cached_lookup prover benchmark * fix: p3-maybe-rayon `parallel` feature was not on (#28) * fix: p3-maybe-rayon `parallel` feature was not on feature is `parallel` not `rayon` * chore: simplify code --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.