feat: Partitioned Air Builder by jonathanpwang · Pull Request #17 · openvm-org/openvm

jonathanpwang · 2024-05-14T18:57:59Z

Adds integration tests for AIR with partitioned main trace (aka cached trace) using SumAir.

Fix: eval_permutation_constraints didn't support partitioned main before
Added some extra functionality to KeygenBuilder to manage the matrix commitment graph when adding cached traces
Until we separate out MockProver into separate struct, add a thread_local flag for whether debug builder is used to do debug constraint checks.

…actions

nyunyunyunyu · 2024-05-14T21:31:06Z

+    let mut trace_builder = TraceCommitmentBuilder::new(prover.pcs());
+    // Demonstrate y is cached
+    let y_data = trace_builder.committer.commit(vec![y_trace.clone()]);
+    trace_builder.load_cached_trace(y_trace, y_data);


Should SingleMatrixCommitPtr be an argument of load_cached_trace/load_trace? Otherwise developers have to remember the order of all trace matrices.

Let me see what I can do

edit: let me make it a separate PR

nyunyunyunyu

Haven't finished #3 yet but this PR LGTM.

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * test: added ListChip and a test involving RangeCheckerChip and ListChip * chore: changed to using determinstic seed * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * test: testing thread safety and other improvements * test: testing thread safety and other improvements * test: generating traces in parallel * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * test: testing RangeCheckerChip * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: added XorChip * chore: small fix * feat: add indexless cached lookup test for partitioned Air with interactions * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * feat: added relative indexing and some documentation * wip * chore: simplifying trace.rs * chore: rename crates `afs-stark-backend, afs-derive` - `afs-middleware` -> `afs-stark-backend` - `afs-middleware-derive` -> `afs-derive` Imports can be handled by global find/replace. * chore: fix github workflow * chore: fix workflow name * chore: set up concurrency for workflow * chore: added test-utils crate * chore: removing the xor chip * wip * chore: moving the tests to a tests/ directory in test-utils crate * chore: fixing imports and moving cached_lookup to stark-backend --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` * feat: add instrumented hash/compress * chore: return instrument counters since fields are private * feat: prelim verifier instrumentation * feat: full benchmark writing to csv * chore: turn off instrumenting during proving * fix: instrument not properly on * fix: flush writer * chore: clean up config module * chore(chips): remove old test config module * feat: add `StarkEngine` for convenience * feat: add cached_lookup prover benchmark * fix: p3-maybe-rayon `parallel` feature was not on (#28) * fix: p3-maybe-rayon `parallel` feature was not on feature is `parallel` not `rayon` * chore: simplify code --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * test: added ListChip and a test involving RangeCheckerChip and ListChip * chore: changed to using determinstic seed * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * test: testing thread safety and other improvements * test: testing thread safety and other improvements * test: generating traces in parallel * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * test: testing RangeCheckerChip * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: added XorChip * chore: small fix * feat: add indexless cached lookup test for partitioned Air with interactions * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * feat: added relative indexing and some documentation * wip * chore: simplifying trace.rs * chore: rename crates `afs-stark-backend, afs-derive` - `afs-middleware` -> `afs-stark-backend` - `afs-middleware-derive` -> `afs-derive` Imports can be handled by global find/replace. * chore: fix github workflow * chore: fix workflow name * chore: set up concurrency for workflow * chore: added test-utils crate * chore: removing the xor chip * wip * chore: moving the tests to a tests/ directory in test-utils crate * chore: fixing imports and moving cached_lookup to stark-backend --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

* wip: refactor to use commit pointers * wip: permutation trace from partitioned main * wip: fix previous rebase * wip: show new interface * chore: rename ChipsetProver to MultiTraceStarkProver * feat: quotient refactor done * feat: prover done * chore: split out prove function into general post-trace part * feat: finished verifier * feat: keygen builder * chore: move fib triple test into same file * feat: preliminary docs on STARK backend scope/support (#16) * feat: add backend readme * fix: link * fix: link * fix: latex * chore: fix typo * chore: add code references --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com> * chore: make DebugBuilder `after_challenge` consistent with other builders * chore: clean up if statement * chore: fix fmt * chore: fix previous merge and remove tracing No need for tracing on non-benchmark tests * chore: fix lint * feat: Partitioned Air Builder (#17) * fix: `eval_permutation_constraints` must handle partitioned_main * feat: integration test with cached trace * fix: forgot to add test files * chore: rename folder to `partitioned_sum_air` * chore: add test utils module * feat: add indexless cached lookup test for partitioned Air with interactions * chore: fix typo * feat: `add_main_matrix(width)` placeholder with mat width * chore: switch from RefCell to Arc Mutex * chore: address review comment * chore: rename `MatrixCommitmentPointers` * feat: add instrumented hash/compress * chore: return instrument counters since fields are private * feat: prelim verifier instrumentation * feat: full benchmark writing to csv * chore: turn off instrumenting during proving * fix: instrument not properly on * fix: flush writer * chore: clean up config module * chore(chips): remove old test config module * feat: add `StarkEngine` for convenience * feat: add cached_lookup prover benchmark * fix: p3-maybe-rayon `parallel` feature was not on (#28) * fix: p3-maybe-rayon `parallel` feature was not on feature is `parallel` not `rayon` * chore: simplify code --------- Co-authored-by: Yi Sun <yi-sun@users.noreply.github.com>

…alid rows (#17)

…ications (#29) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * Use private repo for stark-backend (#11) * temp(ci): switch riscv AMI for runner (#14) * [chore] Update DSL verify to match plonky3 (#5) * Update DSL verify to match plonky3 * fix: transpose state for p3-keccak tracegen * chore: add comment linking plonky3 issue * Update stark-backend commit --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * Use full commit in openvm-stark-backend revision (#18) * chore: update `stark-backend` commit (#19) * [fix] `Rv32BaseAluAdapterAir` unconstrained register reads (#25) * Create pull_request_template.md (#26) * [fix] Poseidon2 verify_batch opcode can send to execution bus for invalid rows (#17) * [fix] Rust memory allocation overflow (#13) * Fix and add test * Fix lint error * Update crates/toolchain/platform/src/memory.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] Constrain `final_hash` in sha256 air to address audit finding (#12) * [fix] properly constrain final_hash in sha256 air * Add negative test for underconstrained final_hash. It was manually checked that this new test would have passed before the change. * [fix] IsLtArraySubAir (#9) * add fix * add tests * remove diff_val * chore: update comment * chore: no try_inverse --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] `Rv32BaseAluAdapterAir` immediate limbs not range-checked (#8) * fix local_as2 * range check imm limbs * add count for range check * add test for unconstrained imm limb * fix MemoryTester chip trace height * add test for unconstrained rs2 read * Revert "fix local_as2" This reverts commit ef83121bf1796874affaca4682dbb4f9f051b079. * Revert "add count for range check" This reverts commit 5252444dfeaf41e7c336648ad92c4736f48ead9d. * Revert "range check imm limbs" This reverts commit 2e2937536069ae66849fdf7bba9ea509065d17fe. * fix unconstrained imm limbs * fix local_rs2_as test * fix lint * Update extensions/rv32im/circuit/src/base_alu/tests.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix: fixed SHA2 subair trace generation and the testing (#28) * fix: loadstore sign of immediate (#4) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: loadstore sign of immediate * fix: prints and test * fix: load_sign_extend tests * Update docs/specs/ISA.md * clarify notation and sign extension in ISA spec * fix reveal transpiler spec --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix transpiler * fix loadstore adapter * fix store transpiler * fix tests * add e2e test * fix docs * fix: jalr imm_sign (#30) * optimize record struct packing * chore: use from_bool * chore: derive_more feature in bench * fix bench * fix --------- Co-authored-by: Xinding Wei <weixinding@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Golovanov399 <Golovanov12345@gmail.com> Co-authored-by: Avaneesh-axiom <avaneeshk@intrinsictech.xyz> Co-authored-by: Arayi Khalatyan <127004086+arayikhalatyan@users.noreply.github.com>

* [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: hintstore mem_ptr and rem_words overflow * fix: is_buffer_start constrain * Use private repo for stark-backend (#11) * temp(ci): switch riscv AMI for runner (#14) * [chore] Update DSL verify to match plonky3 (#5) * Update DSL verify to match plonky3 * fix: transpose state for p3-keccak tracegen * chore: add comment linking plonky3 issue * Update stark-backend commit --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * Use full commit in openvm-stark-backend revision (#18) * chore: update `stark-backend` commit (#19) * [fix] `Rv32BaseAluAdapterAir` unconstrained register reads (#25) * Create pull_request_template.md (#26) * [fix] Poseidon2 verify_batch opcode can send to execution bus for invalid rows (#17) * [fix] Rust memory allocation overflow (#13) * Fix and add test * Fix lint error * Update crates/toolchain/platform/src/memory.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] Constrain `final_hash` in sha256 air to address audit finding (#12) * [fix] properly constrain final_hash in sha256 air * Add negative test for underconstrained final_hash. It was manually checked that this new test would have passed before the change. * [fix] IsLtArraySubAir (#9) * add fix * add tests * remove diff_val * chore: update comment * chore: no try_inverse --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] `Rv32BaseAluAdapterAir` immediate limbs not range-checked (#8) * fix local_as2 * range check imm limbs * add count for range check * add test for unconstrained imm limb * fix MemoryTester chip trace height * add test for unconstrained rs2 read * Revert "fix local_as2" This reverts commit ef83121bf1796874affaca4682dbb4f9f051b079. * Revert "add count for range check" This reverts commit 5252444dfeaf41e7c336648ad92c4736f48ead9d. * Revert "range check imm limbs" This reverts commit 2e2937536069ae66849fdf7bba9ea509065d17fe. * fix unconstrained imm limbs * fix local_rs2_as test * fix lint * Update extensions/rv32im/circuit/src/base_alu/tests.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix: fixed SHA2 subair trace generation and the testing (#28) * fix: loadstore sign of immediate (#4) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: loadstore sign of immediate * fix: prints and test * fix: load_sign_extend tests * Update docs/specs/ISA.md * clarify notation and sign extension in ISA spec * fix reveal transpiler spec --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * seperate the fixes * fix naming * fix: lints --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Xinding Wei <weixinding@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Golovanov399 <Golovanov12345@gmail.com> Co-authored-by: Avaneesh-axiom <avaneeshk@intrinsictech.xyz>

…alid rows (#17)

…ications (#29) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * Use private repo for stark-backend (#11) * temp(ci): switch riscv AMI for runner (#14) * [chore] Update DSL verify to match plonky3 (#5) * Update DSL verify to match plonky3 * fix: transpose state for p3-keccak tracegen * chore: add comment linking plonky3 issue * Update stark-backend commit --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * Use full commit in openvm-stark-backend revision (#18) * chore: update `stark-backend` commit (#19) * [fix] `Rv32BaseAluAdapterAir` unconstrained register reads (#25) * Create pull_request_template.md (#26) * [fix] Poseidon2 verify_batch opcode can send to execution bus for invalid rows (#17) * [fix] Rust memory allocation overflow (#13) * Fix and add test * Fix lint error * Update crates/toolchain/platform/src/memory.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] Constrain `final_hash` in sha256 air to address audit finding (#12) * [fix] properly constrain final_hash in sha256 air * Add negative test for underconstrained final_hash. It was manually checked that this new test would have passed before the change. * [fix] IsLtArraySubAir (#9) * add fix * add tests * remove diff_val * chore: update comment * chore: no try_inverse --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] `Rv32BaseAluAdapterAir` immediate limbs not range-checked (#8) * fix local_as2 * range check imm limbs * add count for range check * add test for unconstrained imm limb * fix MemoryTester chip trace height * add test for unconstrained rs2 read * Revert "fix local_as2" This reverts commit ef83121bf1796874affaca4682dbb4f9f051b079. * Revert "add count for range check" This reverts commit 5252444dfeaf41e7c336648ad92c4736f48ead9d. * Revert "range check imm limbs" This reverts commit 2e2937536069ae66849fdf7bba9ea509065d17fe. * fix unconstrained imm limbs * fix local_rs2_as test * fix lint * Update extensions/rv32im/circuit/src/base_alu/tests.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix: fixed SHA2 subair trace generation and the testing (#28) * fix: loadstore sign of immediate (#4) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: loadstore sign of immediate * fix: prints and test * fix: load_sign_extend tests * Update docs/specs/ISA.md * clarify notation and sign extension in ISA spec * fix reveal transpiler spec --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix transpiler * fix loadstore adapter * fix store transpiler * fix tests * add e2e test * fix docs * fix: jalr imm_sign (#30) * optimize record struct packing * chore: use from_bool * chore: derive_more feature in bench * fix bench * fix --------- Co-authored-by: Xinding Wei <weixinding@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Golovanov399 <Golovanov12345@gmail.com> Co-authored-by: Avaneesh-axiom <avaneeshk@intrinsictech.xyz> Co-authored-by: Arayi Khalatyan <127004086+arayikhalatyan@users.noreply.github.com>

* [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: hintstore mem_ptr and rem_words overflow * fix: is_buffer_start constrain * Use private repo for stark-backend (#11) * temp(ci): switch riscv AMI for runner (#14) * [chore] Update DSL verify to match plonky3 (#5) * Update DSL verify to match plonky3 * fix: transpose state for p3-keccak tracegen * chore: add comment linking plonky3 issue * Update stark-backend commit --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * Use full commit in openvm-stark-backend revision (#18) * chore: update `stark-backend` commit (#19) * [fix] `Rv32BaseAluAdapterAir` unconstrained register reads (#25) * Create pull_request_template.md (#26) * [fix] Poseidon2 verify_batch opcode can send to execution bus for invalid rows (#17) * [fix] Rust memory allocation overflow (#13) * Fix and add test * Fix lint error * Update crates/toolchain/platform/src/memory.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] Constrain `final_hash` in sha256 air to address audit finding (#12) * [fix] properly constrain final_hash in sha256 air * Add negative test for underconstrained final_hash. It was manually checked that this new test would have passed before the change. * [fix] IsLtArraySubAir (#9) * add fix * add tests * remove diff_val * chore: update comment * chore: no try_inverse --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * [fix] `Rv32BaseAluAdapterAir` immediate limbs not range-checked (#8) * fix local_as2 * range check imm limbs * add count for range check * add test for unconstrained imm limb * fix MemoryTester chip trace height * add test for unconstrained rs2 read * Revert "fix local_as2" This reverts commit ef83121bf1796874affaca4682dbb4f9f051b079. * Revert "add count for range check" This reverts commit 5252444dfeaf41e7c336648ad92c4736f48ead9d. * Revert "range check imm limbs" This reverts commit 2e2937536069ae66849fdf7bba9ea509065d17fe. * fix unconstrained imm limbs * fix local_rs2_as test * fix lint * Update extensions/rv32im/circuit/src/base_alu/tests.rs --------- Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * fix: fixed SHA2 subair trace generation and the testing (#28) * fix: loadstore sign of immediate (#4) * [fix] Fix P256 `GENERATOR` and `double_impl` (#2) * fix p256-generator * add host tests for ecc * fix: loadstore sign of immediate * fix: prints and test * fix: load_sign_extend tests * Update docs/specs/ISA.md * clarify notation and sign extension in ISA spec * fix reveal transpiler spec --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> * seperate the fixes * fix naming * fix: lints --------- Co-authored-by: Manh Dinh <manh9203@gmail.com> Co-authored-by: Xinding Wei <weixinding@gmail.com> Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Golovanov399 <Golovanov12345@gmail.com> Co-authored-by: Avaneesh-axiom <avaneeshk@intrinsictech.xyz>

jonathanpwang added 2 commits May 14, 2024 01:17

fix: eval_permutation_constraints must handle partitioned_main

ae9c544

feat: integration test with cached trace

25ecdb3

jonathanpwang requested a review from nyunyunyunyu May 14, 2024 18:58

jonathanpwang changed the title ~~feat(tests): partitioned air~~ feat: Partitioned Air Builder May 14, 2024

jonathanpwang added 4 commits May 14, 2024 15:06

fix: forgot to add test files

bbde6eb

chore: rename folder to partitioned_sum_air

7ca2653

chore: add test utils module

a4f101c

feat: add indexless cached lookup test for partitioned Air with inter…

006b6c6

…actions

nyunyunyunyu reviewed May 14, 2024

View reviewed changes

Comment thread stark-middleware/src/interaction/rap.rs Outdated

Comment thread stark-middleware/tests/partitioned_sum_air/mod.rs Outdated

nyunyunyunyu reviewed May 14, 2024

View reviewed changes

jonathanpwang mentioned this pull request May 14, 2024

Feat/xor chip #18

Merged

chore: fix typo

0e0a4cf

nyunyunyunyu reviewed May 14, 2024

View reviewed changes

Comment thread stark-middleware/tests/partitioned_sum_air/mod.rs

feat: add_main_matrix(width) placeholder with mat width

eb754d9

nyunyunyunyu reviewed May 14, 2024

View reviewed changes

Comment thread stark-middleware/src/prover/mod.rs Outdated

nyunyunyunyu approved these changes May 14, 2024

View reviewed changes

chore: switch from RefCell to Arc Mutex

6553149

jonathanpwang merged commit 06d397a into feat/main_trace_parts May 14, 2024

jonathanpwang deleted the tests/partitioned_air branch May 14, 2024 22:28

jonathanpwang pushed a commit that referenced this pull request Mar 9, 2025

[fix] Poseidon2 verify_batch opcode can send to execution bus for inv…

5c99cbf

…alid rows (#17)

jonathanpwang pushed a commit that referenced this pull request Mar 9, 2025

[fix] Poseidon2 verify_batch opcode can send to execution bus for inv…

6b1d8f1

…alid rows (#17)

github-actions Bot mentioned this pull request May 14, 2026

test(DON'T MERGE): develop-v2.1.0-rv64 #2719

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Partitioned Air Builder#17

feat: Partitioned Air Builder#17
jonathanpwang merged 9 commits into
feat/main_trace_partsfrom
tests/partitioned_air

jonathanpwang commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

nyunyunyunyu May 14, 2024

Uh oh!

jonathanpwang May 14, 2024

Uh oh!

jonathanpwang May 14, 2024

Uh oh!

Uh oh!

Uh oh!

nyunyunyunyu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jonathanpwang commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

nyunyunyunyu May 14, 2024

Choose a reason for hiding this comment

Uh oh!

jonathanpwang May 14, 2024

Choose a reason for hiding this comment

Uh oh!

jonathanpwang May 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nyunyunyunyu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants