Skip to content

Fix contradictions and dead content across command files #4

Description

@larnsce

Problem

An analysis of the repo found concrete contradictions and dead content that produce inconsistent review behavior today, independent of any refactor:

  • commands/review-issue.md (line ~61) calls washr::compile_citation(), which does not exist. CLAUDE.md and commands/review-package.md correctly use washr::update_citation().
  • The License: CC BY 4.0 checklist item exists in CLAUDE.md and review-issue.md but is missing from the issue body template in review-package.md, so the created metadata issue lacks the license check.
  • commands/README.md says "Work on specific issue (1-5)" and review-package-slash-command.md says "I'll create 5 GitHub issues"; the actual workflow has 4 issues (metadata, data, docs, tests).
  • commands/review-status.md uses handlebars syntax ({{#if metadata-closed}}) that never executes; there is no template engine.
  • commands/review-package-slash-command.md is a legacy duplicate of review-package.md from an earlier iteration and is referenced by nothing.

Tasks

  • Replace washr::compile_citation() with washr::update_citation() in review-issue.md
  • Add the CC BY 4.0 license item to the metadata issue template in review-package.md
  • Correct "issues 1-5" and "5 issues" references to the 4-issue workflow
  • Remove or replace the non-executing handlebars blocks in review-status.md
  • Delete review-package-slash-command.md

These are quick, self-contained fixes and a prerequisite for the checklist consolidation (see the single-source-of-truth issue).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions