Drop POST_HEADER_TEXT support. - #1533
Open
drgrice1 wants to merge 1 commit into
Open
Conversation
There is no valid reason for a problem to use `POST_HEADER_TEXT`. Anything that you want after the HTML `head` can be added to the problem text itself. There was an invalid comment about iframes suggesting that this method be used if a page embedded in an iframe contains a form. However, it does not need to be outside of the problem form. It is in an iframe which is a completely separate page, and will not conflict with the outer page's form. Note that a problem author can still add to the `head` section of the HTML page with `HEADER_TEXT`. This method is not used by any problem in the OPL or Contrib.
drgrice1
force-pushed
the
drop-post-header-text
branch
from
September 4, 2026 21:52
4f65a32 to
e3b6db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no valid reason for a problem to use
POST_HEADER_TEXT. Anything that you want after the HTMLheadcan be added to the problem text itself. There was an invalid comment about iframes suggesting that this method be used if a page embedded in an iframe contains a form. However, it does not need to be outside of the problem form. It is in an iframe which is a completely separate page, and will not conflict with the outer page's form.Note that a problem author can still add to the
headsection of the HTML page withHEADER_TEXT.This method is not used by any problem in the OPL or Contrib.
I have had this sitting here for 3 years. I am pulling the trigger on it.