Add handling for a new LTI setting: $block_lti_create_user #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intended for use in an LTI course where automatic LTI account creation is not desired, ex. after the end of a semester if new accounts may potentially be added to the LMS. The setting $block_lti_create_user = 1; can be added to the course.conf file.
Member
Author
|
Since the new code is only triggered is someone adds a new setting to their control files, I think that it is reasonable to make this a last minute addition to the WW 2.15 code. I have tested it on a production server using LTI, and the code does prevent new account creation when the special setting is added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling for a new LTI setting:
$block_lti_create_userintended for use in an LTI course where automatic LTI account creation is not desired, ex. after the end of a semester if new accounts may potentially be added to the LMS. The following setting can be added to thecourse.conffile:By default, accounts will be created, such as when this variable is not defined.
The
return 0;is used to trigger a general authentication error rather than a page full of strange warning that a student would not understand.Some formatting cleanup was done, but only to the inner blocks, so that the indentation of the outer blocks remain in sync with the existing code.