-
-
Notifications
You must be signed in to change notification settings - Fork 166
Add support for a 2 stage Docker build process + support graceful Apache restart #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a 2 stage Docker build process + support graceful Apache restart #1404
Conversation
Modify startup so that docker container exec -it webwork2_app_1 /usr/sbin/apachectl graceful can be used to restart Apache in the container in a "nice" way without stopping the running container. Minor fixes.
drgrice1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I have tested the build steps and it works. There is an issue with the permissions on htdocs/tmp with the default build that needs to be resolved.
|
the htdocs/tmp permission issue is addressed in my upcoming pull request to patch the 2 stage docker process. |
I see that. I see that you did it without the recursive flag as suggested. |
|
Note: this PR does not fix the |
|
I will go ahead and merge this unless someone objects. It only affects the docker build, and seems to work well for that aside from the mentioned issues that are fixed in @mgage's pull request. |
|
I'm in favor of merging this PR. It will make it easier for me to organize the additional minor changes I'd like to add. |
…graceful-restart Add support for a 2 stage Docker build process + support graceful Apache restart
Docker improvements:
docker container exec -it webwork2_app_1 /usr/sbin/apachectl graceful:2 stage build process
The first stage does all the OS level work, and involves installing several hundred ubuntu packages (and some CPAN Perl packages), so takes quite some time.
The second stage installs WeBWorK, and is relatively fast.
Force rebuild of OS later