Modify listCourses to also test for the existence of the course_user table #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd ignore directories for which there is no such table.
mgage
reviewed
Jul 6, 2021
Member
mgage
left a comment
mgage
left a comment
There was a problem hiding this comment.
code looks clear and good. I'll pull and test it later today.
mgage
approved these changes
Jul 6, 2021
Member
mgage
left a comment
mgage
left a comment
There was a problem hiding this comment.
worked well for me. I introduced a few empty directories and they did not appear in the list. There was no noticeable speed hit. The empty directories also did not appear in the admin view of courses
pstaabp
approved these changes
Jul 7, 2021
drgrice1
approved these changes
Jul 7, 2021
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
I think this is good. I tested it quickly, and it works as promised.
drgrice1
pushed a commit
that referenced
this pull request
Jul 7, 2021
…nd ignore directories for which there is no such table. (#1434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
listCoursestest also for the existence of thecourse_usertable and ignore directories for which there is no such table.I chose the
course_usertable, as that is one whose absence will quickly cause problems.This is intended to address the issue that the current code would assume that any subdirectory in the courses directory corresponded to a "real" course.
That issue also was mentioned in #1424 as
bin/update-OPL-statisticsmisbehaves where there are subdirectories which do not correspond to courses. Several other parts of the code-base will have similar various problems handling incorrect names from the old code.For example, until this PR, the code which generates the list of courses for the "home page" at "/webwork2" on the server could include links for names of subdirectories which are not valid courses.