Skip to content

Conversation

@taniwallach
Copy link
Member

Force a few more things to be left-to-right where in Hebrew courses the default would have been right-to-left which seems less appropriate. The changes should not have an effect on courses in left-to-right languages.

@taniwallach taniwallach requested review from drgrice1 and pstaabp July 14, 2022 10:28
Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably a lot more of this needed isn't there. How many places in the interface do we display a file name, email address, or username?

@drgrice1
Copy link
Member

This is trivial enough, that I will go ahead and merge.

@drgrice1 drgrice1 merged commit 3795745 into openwebwork:WeBWorK-2.17 Jul 14, 2022
@taniwallach
Copy link
Member Author

There is probably a lot more of this needed isn't there. How many places in the interface do we display a file name, email address, or username?

There probably are more - but the FileManager.pm has been annoying in Hebrew courses for a long time, but not that so much else is fixed - was more glaringly noticable. The other places were places I realized there would be filenames/paths+filenames quickly and use often.

Whatever else comes up will wait for the future.

@taniwallach taniwallach deleted the more-rtl-mods branch July 14, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants