Update third party libraries to their latest versions. #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should there be a hotfix to 2.17 for the luxon vulnerability? |
Member
Author
|
It wouldn't be a bad idea. I guess I could just open the dependabot's pull request, and merge it. |
Member
|
Heads up that after checking out this branch, you need to
This is probably a good idea. |
pstaabp
approved these changes
Jan 10, 2023
Member
Author
|
Yeah, since this changes the actual libraries that npm installs, you certainly need to run |
drgrice1
force-pushed
the
third-party-lib-update
branch
from
e730b5d to
c6a3c9c
Compare
drgrice1
force-pushed
the
third-party-lib-update
branch
from
c6a3c9c to
9a01f56
Compare
Well, that is except for codemirror. Upgrading to version 6 will require a build system. The upgrade to Bootstrap 5.2.3 requires a few changes to the code. The changes to regain the dark borders on table thead sections are perhaps not necessary. Those borders were not there before the upgrade to the previous version of Bootstrap 5. The previous version forced those borders. It is a new feature that those borders are opt in. This has to be done per table. However, I have become accustomed to those borders, so I opted in. If you feel differently, let me know. In order for the accordion buttons on the ProblemSetDetail.pm page to show up the containing div needs to have the accordion class now. Fortunately with that everything works as it should.
drgrice1
force-pushed
the
third-party-lib-update
branch
from
9a01f56 to
5289352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, that is except for codemirror. Upgrading to version 6 will require a build system.
The upgrade to Bootstrap 5.2.3 requires a few changes to the code.
The changes to regain the dark borders on table thead sections are perhaps not necessary. Those borders were not there before the upgrade to the previous version of Bootstrap 5. The previous version forced those borders. It is a new feature that those borders are opt in. This has to be done per table. However, I have become accustomed to those borders, so I opted in. If you feel differently, let me know.
In order for the accordion buttons on the ProblemSetDetail.pm page to show up the containing div needs to have the accordion class now. Fortunately with that everything works as it should.