stop supporting a typo #2120
Merged
stop supporting a typo #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
drgrice1
approved these changes
Jul 19, 2023
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
I am fine with this. I didn't really want to add the formated... date parameters in lib/WeBWorK/Utils/Rendering.pm, but didn't want to stir up the controversy at that time.
Contributor
Author
|
Thanks, I made those deletions. |
pstaabp
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be controversial, and I'm fine if this is rejected.
My problem with supporting this typo in old set header files, is that while doing dev work, I saw "formated" appear in a list of hash keys and I thought surely that's a typo. So I wasted time looking into it only to find it is supposed to be there. But is it time to make people correct their typos?