move help link outside of h1 #2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
approved these changes
Jul 20, 2023
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
This looks good. I suggest a small tweak though.
Comment on lines
380
to
388
| h1.page-title { | ||
| font-size: 31.5px; | ||
| line-height: 35px; | ||
| display: inline-block; | ||
| } | ||
| h1.page-title + a { | ||
| font-size: 31.5px; | ||
| margin-left: 0.5rem; | ||
| } |
Member
There was a problem hiding this comment.
I think the help h.page-title + a also needs the line-height. Otherwise the page title gets uneven spacing above and below it.
Also, take advantage of scss here. So make this:
Suggested change
| h1.page-title { | |
| font-size: 31.5px; | |
| line-height: 35px; | |
| display: inline-block; | |
| } | |
| h1.page-title + a { | |
| font-size: 31.5px; | |
| margin-left: 0.5rem; | |
| } | |
| h1.page-title { | |
| font-size: 31.5px; | |
| line-height: 35px; | |
| display: inline-block; | |
| & + a { | |
| font-size: 31.5px; | |
| line-height: 35px; | |
| margin-left: 0.5rem; | |
| } | |
| } |
pstaabp
approved these changes
Jul 20, 2023
Member
|
Oops. The changes hadn't been made yet. |
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jul 20, 2023
This is just my suggestion for openwebwork#2139 that didn't get applied before it was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the question mark help icons next to each h1 outside of the h1 (but still visually in basically the same place).
Without this, when you look at a heading tree for a page, you see a little question mark at the end of each h1, and that shouldn't be in the actual heading.