Add the hidden authentication fields to the LTI update form. #2836
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Oct 29, 2025
Contributor
|
Due to the session management via key issue, should this be a hot fix as well? |
Member
Author
|
I am okay with a hotfix. Although, since no one has complained about it, it may not be a big issue. The "key" setting for |
The content generator `hidden_authen_fields` method should be called in all page forms, but was not added ot the form in the LTI update page. As a result if you are acting as a student, go to that page, and click "Update Grades", then the acting ceases. Even worse, if `session_management_via` is set to "key", and you click "Update Grades", then you are sent to the login page, and have to login again in order for the form to submit. I missed this when this page was created. @somiaj observed the issue when acting as another user on the page.
drgrice1
force-pushed
the
lti-update-hidden-auth
branch
from
74e8118 to
8036401
Compare
dlglin
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content generator
hidden_authen_fieldsmethod should be called in all page forms, but was not added ot the form in the LTI update page. As a result if you are acting as a student, go to that page, and click "Update Grades", then the acting ceases. Even worse, ifsession_management_viais set to "key", and you click "Update Grades", then you are sent to the login page, and have to login again in order for the form to submit. I missed this when this page was created. @somiaj observed the issue when acting as another user on the page.