Skip to content

Conversation

@taniwallach
Copy link
Member

Add installation (in Docker) and module test for MooX::Options which is needed by new code in #959

@mgage
Copy link
Member

mgage commented Aug 24, 2019

Despite my tentative concerns about unnecessary bloat listed in comments for PR #959 I plan to merge this pull request. It simply makes #959, which is already merged, complete. It may be that Moo is sufficiently useful (above and beyond Class::Accessor) and light weight that we want to make it a permanent part of WW. In any case that decision can wait until we make a comprehensive review of WeBWorK and engage in some basic refactoring. I'm personally looking forward to the idea of basic refactoring as we bring webwork3 on line. Any 20 year old project needs to be rejuvenated from time to time.

@mgage mgage merged commit 8f4afcc into openwebwork:WeBWorK-2.15 Aug 24, 2019
@taniwallach taniwallach deleted the add-moox-options branch August 24, 2019 18:10
@drgrice1
Copy link
Member

This pull request should not have been merged, at least not until pull request #959 is merged. At this point, I am not sure if that pull request will be merged or not for ww 2.16. If it is not, then this should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants