This repository was archived by the owner on May 19, 2020. It is now read-only.
Fix for invalid IPv6 or IPv4 ipaddress and subnet#29
Merged
nemesifier merged 1 commit intoopenwisp:masterfrom Jul 6, 2018
Merged
Fix for invalid IPv6 or IPv4 ipaddress and subnet#29nemesifier merged 1 commit intoopenwisp:masterfrom
nemesifier merged 1 commit intoopenwisp:masterfrom
Conversation
Implements and closes openwisp#28
nemesifier
reviewed
Jul 6, 2018
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
see my comments for minor cleanups and please reply to my concern:
after removing your fix, only test_ipaddress_invalid_entry fails, when are the other two tests supposed to fail?
| self.assertContains(response, '<h3>Used IP address</h3>') | ||
|
|
||
| def test_subnet_invalid_entry(self): | ||
|
|
Member
There was a problem hiding this comment.
please remove this blank line
|
|
||
| def test_ipaddress_invalid_entry(self): | ||
| subnet = self._create_subnet(dict(subnet="10.0.0.0/24", description="Sample Subnet")) | ||
|
|
nemesifier
approved these changes
Jul 6, 2018
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
I'll handle the fixes (see my comments in the general chat).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements and closes #28