Skip to content

[ci] Browser test timeout to 30s#342

Merged
nemesifier merged 3 commits intoopenwisp:masterfrom
dee077:chromedriver
Feb 28, 2025
Merged

[ci] Browser test timeout to 30s#342
nemesifier merged 3 commits intoopenwisp:masterfrom
dee077:chromedriver

Conversation

@dee077
Copy link
Copy Markdown
Member

@dee077 dee077 commented Feb 27, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #269.

Description of Changes

  • Separate the step in job Test and Coverage for Unit tests and Browser tests in ci.yml.
  • Set browser test timeout to 30s in only ci.yml as it sometimes runs slower and causes test failure.

@dee077 dee077 closed this Feb 27, 2025
@dee077 dee077 reopened this Feb 27, 2025
@dee077 dee077 changed the base branch from chromedriver to master February 27, 2025 23:18
@dee077 dee077 closed this Feb 27, 2025
@dee077 dee077 reopened this Feb 27, 2025
try {
const options = new chrome.Options();
options.addArguments("--headless");
options.addArguments("--remote-debugging-pipe");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this I can't run it locally... same problem as before.
I am trying to add it back.

@nemesifier nemesifier added the github_actions Pull requests that update GitHub Actions code label Feb 28, 2025
@nemesifier nemesifier merged commit 1d606a7 into openwisp:master Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tests] Increase test coverage and add basic browser tests

2 participants